Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Unskip partial results Serverless tests #166410

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Sep 14, 2023

Summary

This PR unskips the partial results Serverless tests. I ran 100x flaky test runs against each project type to confirm they should no longer be flaky.

Flaky test runs:

Resolves #165563.
Resolves #165612.
Resolves #165763.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 14, 2023
@davismcphee davismcphee self-assigned this Sep 14, 2023
@davismcphee davismcphee marked this pull request as ready for review September 15, 2023 20:58
@davismcphee davismcphee requested a review from a team as a code owner September 15, 2023 20:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

before(async () => {
// TODO: Serverless tests require login first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Serverless tests require login first
// Serverless tests require login first

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 8e800ee into elastic:main Sep 20, 2023
@davismcphee davismcphee deleted the unskip-partial-results branch September 20, 2023 00:04
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 20, 2023
@watson watson added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment