-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Unskip partial results Serverless tests #166410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
labels
Sep 14, 2023
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
approved these changes
Sep 16, 2023
before(async () => { | ||
// TODO: Serverless tests require login first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// TODO: Serverless tests require login first | |
// Serverless tests require login first |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @davismcphee |
kibanamachine
added
v8.11.0
backport:skip
This commit does not require backporting
labels
Sep 20, 2023
watson
added
the
Project:Serverless
Work as part of the Serverless project for its initial release
label
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Project:Serverless
Work as part of the Serverless project for its initial release
release_note:skip
Skip the PR/issue when compiling release notes
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR unskips the partial results Serverless tests. I ran 100x flaky test runs against each project type to confirm they should no longer be flaky.
Flaky test runs:
.only
): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3114Resolves #165563.
Resolves #165612.
Resolves #165763.
Checklist
For maintainers