Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit available spaces to 1 for risk engine #167110

Merged
merged 18 commits into from
Sep 29, 2023
Merged

Limit available spaces to 1 for risk engine #167110

merged 18 commits into from
Sep 29, 2023

Conversation

nkhristinin
Copy link
Contributor

Summary

Limit available spaces to 1 for risk engine

Screenshot 2023-09-25 at 08 15 47

@nkhristinin nkhristinin requested a review from a team as a code owner September 25, 2023 06:16
@nkhristinin nkhristinin added the release_note:skip Skip the PR/issue when compiling release notes label Sep 25, 2023
@nkhristinin nkhristinin requested a review from a team as a code owner September 25, 2023 08:21
e40pud
e40pud approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left small comment.

x-pack/plugins/security_solution/public/entity_analytics/translations.ts Outdated
@@ -248,7 +248,7 @@ export const UPDATE_PANEL_GO_TO_DISMISS = i18n.translate(
export const getMaxSpaceTitle = (maxSpaces: number) =>
i18n.translate('xpack.securitySolution.riskScore.maxSpacePanel.title', {
defaultMessage:
'Entity Risk Scoring in the current version can run in {maxSpaces} Kibana spaces.',
'Entity Risk Scoring in the current version can run in {maxSpaces} Kibana space.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could consider "plural" form here to avoid changing translation in future when we update spaces count? Something like: 'Entity Risk Scoring in the current version can run in {maxSpaces} Kibana {maxSpaces, plural, =1 {space} other {spaces}}.'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@nkhristinin nkhristinin requested a review from a team September 25, 2023 13:33
@nkhristinin nkhristinin added the ui-copy Review of UI copy with docs team is recommended label Sep 25, 2023
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Changing alert status Closing alerts Updates count table whenever alert status is updated in table Updates count table whenever alert status is updated in table
  • [job] [logs] Investigations - Security Solution Cypress Tests #6 / Discover Timeline State Integration saved search should rename the saved search on timeline rename should rename the saved search on timeline rename
  • [job] [logs] FTR Configs #22 / serverless common UI Index Management Create enrich policy "before all" hook for "shows create enrich policies page and docs link"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nkhristinin nkhristinin merged commit 7aee2e2 into elastic:main Sep 29, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic approved these changes

@e40pud e40pud e40pud approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes ui-copy Review of UI copy with docs team is recommended v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nkhristinin @yctercero @kibana-ci @e40pud @natasha-moore-elastic @kibanamachine