Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard navigation] Functional tests for links panel #167324

Merged
merged 7 commits into from
Sep 28, 2023
Merged

[Dashboard navigation] Functional tests for links panel #167324

merged 7 commits into from
Sep 28, 2023

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented Sep 26, 2023 •
edited
Loading

Summary

Adds functional tests to the Links panel feature branch.

Flaky test runner forthcoming...

@nickpeihl nickpeihl added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Sep 28, 2023
@nickpeihl nickpeihl requested a review from Heenawter September 28, 2023 14:10
@nickpeihl nickpeihl marked this pull request as ready for review September 28, 2023 14:10
@nickpeihl nickpeihl requested review from a team as code owners September 28, 2023 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

jbudz
jbudz approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr_configs.yml, packages/kbn-test

Heenawter
Heenawter approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough tests - great job!! 🎉 Thanks so much for doing all the work here. I left a few thoughts, but absolutely nothing that needs to be addressed critically.

src/plugins/links/public/components/external_link/external_link_component.tsx Show resolved Hide resolved
src/plugins/links/public/components/dashboard_link/dashboard_link_component.tsx Show resolved Hide resolved
src/plugins/links/public/components/editor/link_destination.tsx Show resolved Hide resolved
test/functional/apps/dashboard_elements/links/links_create_edit.ts Outdated Show resolved Hide resolved
test/functional/page_objects/dashboard_page_links.ts
import { LinksLayoutType } from '@kbn/links-plugin/common/content_management';
import { FtrService } from '../ftr_provider_context';

export class DashboardPageLinks extends FtrService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🤩

test/functional/page_objects/dashboard_page_links.ts
Comment on lines +157 to +163
await this.retry.try(async () => {
await this.browser.pressKeys(this.browser.keys.SPACE);
linkToMove.elementHasClass('euiDraggable--isDragging');
});
for (let i = 0; i < steps; i++) {
await this.browser.pressKeys(reverse ? this.browser.keys.UP : this.browser.keys.DOWN);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

test/functional/apps/dashboard_elements/links/links_navigation.ts Outdated Show resolved Hide resolved
@nickpeihl nickpeihl merged commit e0b2c38 into elastic:navigation-embeddable Sep 28, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 28, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #5 / checking migration metadata changes on all registered SO types detecting migration related changes in registered types
  • [job] [logs] FTR Configs #44 / links panel links panel editing can reorder links in an existing panel
  • [job] [logs] FTR Configs #44 / links panel links panel editing can reorder links in an existing panel
  • [job] [logs] FTR Configs #54 / serverless search UI empty pages should show search specific empty page in dashboards
  • [job] [logs] FTR Configs #54 / serverless search UI Importing an existing dashboard does not show the unsaved changes badge in edit mode
  • [job] [logs] Jest Integration Tests #6 / split .kibana index into multiple system indices when migrating from a legacy version performs v1 migration and then relocates saved objects into different indices, depending on their types

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 20.4KB 21.2KB +880.0B
presentationUtil 75.8KB 76.0KB +219.0B
uiActionsEnhanced 135.5KB 135.5KB +41.0B
total +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
links 32.2KB 32.2KB -27.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
_data_stream_timestamp - 1 +1
_doc_count - 1 +1
_tier - 1 +1
apm-server-schema - 2 +2
apm-service-group - 5 +5
application_usage_daily - 2 +2
config - 2 +2
config-global - 2 +2
coreMigrationVersion - 1 +1
created_at - 1 +1
event_loop_delays_daily - 2 +2
file - 11 +11
file-upload-usage-collection-telemetry - 3 +3
fileShare - 5 +5
guided-onboarding-guide-state - 3 +3
infrastructure-monitoring-log-view - 2 +2
legacy-url-alias - 7 +7
managed - 1 +1
ml-job - 6 +6
ml-module - 11 +11
ml-trained-model - 7 +7
monitoring-telemetry - 2 +2
namespace - 1 +1
namespaces - 1 +1
observability-onboarding-state - 2 +2
originId - 1 +1
references - 4 +4
sample-data-telemetry - 3 +3
slo - 10 +10
space - 3 +3
synthetics-monitor - 32 +32
tag - 4 +4
type - 1 +1
typeMigrationVersion - 1 +1
ui-metric - 2 +2
updated_at - 1 +1
upgrade-assistant-ml-upgrade-operation - 3 +3
upgrade-assistant-reindex-operation - 3 +3
uptime-synthetics-api-key - 2 +2
url - 5 +5
usage-counters - 2 +2
total +159

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Heenawter Heenawter mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickpeihl @elasticmachine @kibana-ci @jbudz @Heenawter @kibanamachine