Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip prebuilt rules Cypress tests #168165

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Oct 5, 2023

Addresses: #161540

Summary

This PR unskips preuilt rules Cypress tests (besides prebuilt_rules_install_update_authorization.cy.ts as it uses non default role).

Flaky test runner

prebuilt_rules folder 150 runs 🟢

@maximpn maximpn added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.11.0 labels Oct 5, 2023
@maximpn maximpn self-assigned this Oct 5, 2023
@maximpn maximpn requested a review from banderror October 6, 2023 11:37
@maximpn maximpn force-pushed the unskip-prebuilt-rules-tests branch from 47451ed to 58bc943 Compare October 6, 2023 11:38
@maximpn maximpn marked this pull request as ready for review October 6, 2023 11:38
@maximpn maximpn requested a review from a team as a code owner October 6, 2023 11:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #3 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name

Metrics [docs]

✅ unchanged

History

  • 💛 Build #165782 was flaky 47451ed55c54a9c5c2bd3e2c1b67125e8ade8e45

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maximpn maximpn merged commit 6c5603c into elastic:main Oct 6, 2023
@maximpn maximpn deleted the unskip-prebuilt-rules-tests branch October 6, 2023 20:05
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2023
**Addresses:** elastic#161540

## Summary

This PR unskips preuilt rules Cypress tests (besides `prebuilt_rules_install_update_authorization.cy.ts` as it uses non default role).

## Flaky test runner

[prebuilt_rules folder 150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3384) 🟢

(cherry picked from commit 6c5603c)
kibanamachine added a commit that referenced this pull request Oct 6, 2023
…) (#168292)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskip prebuilt rules Cypress tests
(#168165)](#168165)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-06T20:05:43Z","message":"[Security
Solution] Unskip prebuilt rules Cypress tests
(#168165)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips preuilt rules Cypress tests (besides
`prebuilt_rules_install_update_authorization.cy.ts` as it uses non
default role).\r\n\r\n## Flaky test runner\r\n\r\n[prebuilt_rules folder
150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3384)
🟢","sha":"6c5603c95223f5ae9883195c7a5ed126513932c1","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","v8.11.0","v8.12.0"],"number":168165,"url":"https://github.com/elastic/kibana/pull/168165","mergeCommit":{"message":"[Security
Solution] Unskip prebuilt rules Cypress tests
(#168165)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips preuilt rules Cypress tests (besides
`prebuilt_rules_install_update_authorization.cy.ts` as it uses non
default role).\r\n\r\n## Flaky test runner\r\n\r\n[prebuilt_rules folder
150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3384)
🟢","sha":"6c5603c95223f5ae9883195c7a5ed126513932c1"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168165","number":168165,"mergeCommit":{"message":"[Security
Solution] Unskip prebuilt rules Cypress tests
(#168165)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips preuilt rules Cypress tests (besides
`prebuilt_rules_install_update_authorization.cy.ts` as it uses non
default role).\r\n\r\n## Flaky test runner\r\n\r\n[prebuilt_rules folder
150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3384)
🟢","sha":"6c5603c95223f5ae9883195c7a5ed126513932c1"}}]}] BACKPORT-->

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
**Addresses:** elastic#161540

## Summary

This PR unskips preuilt rules Cypress tests (besides `prebuilt_rules_install_update_authorization.cy.ts` as it uses non default role).

## Flaky test runner

[prebuilt_rules folder 150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3384) 🟢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants