Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Enable updating system actions through the Bulk Edit Rule API #168226

Merged
merged 18 commits into from
Oct 27, 2023
Merged

[Alerting] Enable updating system actions through the Bulk Edit Rule API #168226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b310c8a
Support system actions in the create rule API
cnasikas Oct 3, 2023
6ec30eb
Init system action types
cnasikas Oct 3, 2023
40306ce
Create isSystemAction helper
cnasikas Oct 3, 2023
0fab8a8
Use the isSystemAction helper in the executor
cnasikas Oct 3, 2023
5024714
Pass the isSystemAction to the rules factory
cnasikas Oct 3, 2023
3bda9b9
Add test utils for system actions
cnasikas Oct 3, 2023
9fb4ab9
Merge branch 'sa_executor_types' into so_create_rule_api
cnasikas Oct 3, 2023
d68f1cb
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Oct 3, 2023
f9dccc5
Do not persist the type of the action in ES
cnasikas Oct 6, 2023
54fd67a
Merge branch 'system_actions_mvp' into sa_executor_types
cnasikas Oct 6, 2023
2fe3842
Merge branch 'sa_executor_types' into so_create_rule_api
cnasikas Oct 6, 2023
2e50e0d
Allow sysetm actions in the bulk edit API
cnasikas Oct 6, 2023
432d35c
Fix tests
cnasikas Oct 6, 2023
b66fd6d
Merge branch 'system_actions_mvp' into sa_bulk_edit_api
guskovaue Oct 26, 2023
853d376
fixes after merge with system_actions_mvp branch
guskovaue Oct 26, 2023
bc18d27
fix bulk edit rule unit tests
guskovaue Oct 27, 2023
865b46e
fix typo
guskovaue Oct 27, 2023
5045a47
fix integrational tests
guskovaue Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/alerting/common/routes/rule/apis/bulk_edit/schemas/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ruleSnoozeScheduleSchemaWithValidation = schema.object(
);

const ruleActionSchema = schema.object({
group: schema.string(),
group: schema.maybe(schema.string()),
id: schema.string(),
params: schema.recordOf(schema.string(), schema.any(), { defaultValue: {} }),
uuid: schema.maybe(schema.string()),
Expand Down
Loading
Loading