Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] color="ghost" button cleanup #169304

Merged
merged 5 commits into from
Oct 23, 2023
Merged

[Security Solution] color="ghost" button cleanup #169304

merged 5 commits into from
Oct 23, 2023

Conversation

cee-chen
Copy link
Contributor

Summary

👋 Hey y'all - EUI will shortly be deprecating the ghost color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).

I'm opening this PR ahead of time for your team so you can test this migration and ensure no regressions have occurred as a result.

Screenshots

non-fullscreen mode fullscreen mode dark mode

Checklist

@cee-chen cee-chen added EUI v8.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 18, 2023
@cee-chen cee-chen mentioned this pull request Oct 18, 2023
Merged
11 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB -401.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 63.2KB 63.2KB -59.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review October 19, 2023 16:56
@cee-chen cee-chen requested review from a team as code owners October 19, 2023 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

angorayc
angorayc approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Tested locally with dark and bright theme, LGTM!

@cee-chen cee-chen added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Oct 23, 2023
@cee-chen
Copy link
Contributor Author

Thank you @angorayc! @elastic/security-threat-hunting-investigations, any chance y'all have time for a review this week?

PhilippeOberti
PhilippeOberti approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team!

@cee-chen cee-chen merged commit 96b1829 into elastic:main Oct 23, 2023
2 checks passed
@cee-chen cee-chen deleted the eui-ghost/security-solution branch October 23, 2023 16:39
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@angorayc angorayc angorayc approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cee-chen @kibana-ci @elasticmachine @angorayc @PhilippeOberti @kibanamachine