Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES UI Shared] Remove old ace based EuiCodeEditor #169613

Merged
merged 9 commits into from
Oct 25, 2023
Merged

[ES UI Shared] Remove old ace based EuiCodeEditor #169613

merged 9 commits into from
Oct 25, 2023

Conversation

sabarasaba
Copy link
Member

Closes #155833

Summary

Given that we have now migrated all the EuiCodeEditor (ace editor) instances to CodeEditor (monaco) with #155833, we can now go ahead and remove the EuiCodeEditor implementation.

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.12.0 labels Oct 24, 2023
@sabarasaba sabarasaba self-assigned this Oct 24, 2023
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba marked this pull request as ready for review October 25, 2023 08:01
@sabarasaba sabarasaba requested review from a team as code owners October 25, 2023 08:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech self-requested a review October 25, 2023 09:24
yuliacech
yuliacech approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for completing this long-standing task, @sabarasaba!
Code changes LGTM 👍 didn't test locally

walterra
walterra approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML related changes LGTM. (code review only since it's just types being changed in the code-owned files)

mdefazio
mdefazio approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there are any double-checks design needs to do for code-editors in the UI. But approving this simply based on the scss file deletions.

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

tomsonpl
tomsonpl approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Osquery (Defend Workflows) lgtm, thanks!

dasansol92
dasansol92 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@dasansol92 dasansol92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under osquery plugin LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / Profiling API tests functions.spec.ts cloud Loading profiling data Functions api "before all" hook in "Functions api"
  • [job] [logs] FTR Configs #48 / serverless security UI Security ML Data frame analytics jobs list "before all" hook in "Data frame analytics jobs list"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esUiShared 232 225 -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 111 97 -14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esUiShared 5.4KB 0.0B -5.4KB
indexManagement 562.1KB 562.1KB -14.0B
osquery 1.0MB 1.0MB -3.0B
total -5.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 156.6KB 155.1KB -1.5KB
osquery 51.3KB 51.1KB -146.0B
total -1.6KB
Unknown metric groups

API count

id before after diff
esUiShared 115 99 -16

async chunk count

id before after diff
esUiShared 1 0 -1

ESLint disabled line counts

id before after diff
esUiShared 12 11 -1

Total ESLint disabled count

id before after diff
esUiShared 12 11 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit 9d0c7d7 into elastic:main Oct 25, 2023
This was referenced May 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@dasansol92 dasansol92 dasansol92 approved these changes

@joeypoon joeypoon joeypoon approved these changes

@yuliacech yuliacech yuliacech approved these changes

@mdefazio mdefazio mdefazio approved these changes

@walterra walterra walterra approved these changes

Assignees

@sabarasaba sabarasaba

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove EuiCodeEditor from es_ui_shared
10 participants
@sabarasaba @elasticmachine @kibana-ci @walterra @mdefazio @yuliacech @joeypoon @dasansol92 @tomsonpl @kibanamachine