Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions][API testing] Refactor commands in package.json #170025

Merged
merged 8 commits into from
Oct 28, 2023
Merged

[Security Solution][Exceptions][API testing] Refactor commands in package.json #170025

merged 8 commits into from
Oct 28, 2023

Conversation

WafaaNasr
Copy link
Contributor

Summary

  • Refactor package.json to remove duplicates
  • Move the new term rules

@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes FTR labels Oct 27, 2023
@WafaaNasr WafaaNasr self-assigned this Oct 27, 2023
@WafaaNasr WafaaNasr marked this pull request as ready for review October 27, 2023 13:04
@WafaaNasr WafaaNasr requested a review from a team as a code owner October 27, 2023 13:04
yctercero
yctercero reviewed Oct 27, 2023
View reviewed changes
...ntegration/test_suites/detections_response/default_license/rule_creation/create_new_terms.ts

// eslint-disable-next-line import/no-default-export
export default ({ getService }: FtrProviderContext) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the tags to the test too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a9d1ffa

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

@WafaaNasr WafaaNasr merged commit 015bbaa into elastic:main Oct 28, 2023
@WafaaNasr WafaaNasr deleted the refactor-package-json branch October 28, 2023 19:38
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WafaaNasr @kibana-ci @yctercero @kibanamachine