[RAM] System action in bulk delete #170741

guskovaue · 2023-11-07T13:58:14Z

Fix: #170392
Meta: #160367

Summary

This PR enables system actions for the Bulk Delete Rule API.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2023-11-08T08:53:51Z

Pinging @elastic/response-ops (Team:ResponseOps)

x-pack/plugins/alerting/server/application/rule/methods/bulk_delete/bulk_delete_rules.test.ts

x-pack/plugins/alerting/server/data/rule/types/rule_attributes.ts

x-pack/plugins/alerting/server/rules_client/lib/get_alert_from_raw.ts

XavierM · 2023-11-09T17:26:57Z

x-pack/plugins/alerting/server/rules_client/methods/bulk_enable.ts

+    } catch (e) {
+      context.logger.warn(`Error validating bulk enabled rule domain object for id: ${id}, ${e}`);
+    }
+    return ruleDomain;


We can avoid the two loop if just do that, correct?

Suggested change

return ruleDomain;

return transformRuleDomainToRule<Params>(ruleDomain);

I've maid this change on bulk enable PR: bb43e3fa3074c88c0a86899f3acae71873e973c2

It'll appear here after merge

XavierM · 2023-11-09T17:28:19Z

x-pack/plugins/alerting/server/rules_client/methods/bulk_enable.ts

+    try {
+      ruleDomainSchema.validate(ruleDomain);
+    } catch (e) {
+      context.logger.warn(`Error validating bulk enabled rule domain object for id: ${id}, ${e}`);
+    }


I will ask @JiaweiWu about that but it is weird to validate and do nothing about it. Let's keep it for now but it is weird

What was the reason behind that?

it was safe guard to make sure that we are dealing with the right type

kibana-ci · 2023-11-14T09:47:44Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #50 / Actions and Triggers app Rule Details Header renders the rule details
[job] [logs] FTR Configs #50 / Actions and Triggers app Rule Details Header renders the rule details
[job] [logs] FTR Configs #12 / Actions API @serverless @ess add_actions adding actions creates rule with a new webhook action
[job] [logs] FTR Configs #34 / Actions API @serverless @ess add_actions adding actions creates rule with a new webhook action
[job] [logs] FTR Configs #12 / Actions API @serverless @ess add_actions adding actions creates rule with a new webhook action
[job] [logs] FTR Configs #34 / Actions API @serverless @ess add_actions adding actions creates rule with a new webhook action
[job] [logs] FTR Configs #45 / Alerting alerts should schedule task, run alert and schedule actions
[job] [logs] FTR Configs #45 / Alerting alerts should schedule task, run alert and schedule actions
[job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts
[job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts
[job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts
[job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alerts
[job] [logs] FTR Configs #39 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkEnableRules superuser at space1 should handle bulk enable of one rule appropriately based on id
[job] [logs] FTR Configs #39 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkEnableRules superuser at space1 should handle bulk enable of one rule appropriately based on id
[job] [logs] FTR Configs #7 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #46 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #67 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #7 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #46 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #67 / Alerting APIs Alerting rules should pass updated rule params to executor
[job] [logs] FTR Configs #13 / Alerting create legacy should handle create alert request appropriately
[job] [logs] FTR Configs #13 / Alerting create legacy should handle create alert request appropriately
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Add index patterns to custom rules with configured data view when data view checkbox is checked: rules are updated Add index patterns to custom rules with configured data view when data view checkbox is checked: rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Add index patterns to custom rules with configured data view when data view checkbox is checked: rules are updated Add index patterns to custom rules with configured data view when data view checkbox is checked: rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Add index patterns to custom rules with configured data view: all rules are skipped Add index patterns to custom rules with configured data view: all rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Add index patterns to custom rules with configured data view: all rules are skipped Add index patterns to custom rules with configured data view: all rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Delete index patterns in custom rules with configured data view: rules are skipped Delete index patterns in custom rules with configured data view: rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Delete index patterns in custom rules with configured data view: rules are skipped Delete index patterns in custom rules with configured data view: rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is checked: rules are updated Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is checked: rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is checked: rules are updated Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is checked: rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is NOT checked:: rules are skipped Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is NOT checked:: rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with a data view only Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is NOT checked:: rules are skipped Overwrite index patterns in custom rules with configured data view when overwrite data view checkbox is NOT checked:: rules are skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with index patterns and rules with a data view Add index patterns to custom rules when overwrite data view checkbox is checked: all rules are updated Add index patterns to custom rules when overwrite data view checkbox is checked: all rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with index patterns and rules with a data view Add index patterns to custom rules when overwrite data view checkbox is checked: all rules are updated Add index patterns to custom rules when overwrite data view checkbox is checked: all rules are updated
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with index patterns and rules with a data view Add index patterns to custom rules: one rule is updated, one rule is skipped Add index patterns to custom rules: one rule is updated, one rule is skipped
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Bulk editing index patterns of rules with index patterns and rules with a data view Add index patterns to custom rules: one rule is updated, one rule is skipped Add index patterns to custom rules: one rule is updated, one rule is skipped
[job] [logs] FTR Configs #22 / detection engine api security and spaces enabled - Group 1 create_rules_bulk creating rules in bulk per-action frequencies actions without frequencies it sets each action's frequency attribute to default value when 'throttle' is undefined
[job] [logs] FTR Configs #22 / detection engine api security and spaces enabled - Group 1 create_rules_bulk creating rules in bulk per-action frequencies actions without frequencies it sets each action's frequency attribute to default value when 'throttle' is undefined
[job] [logs] FTR Configs #22 / detection engine api security and spaces enabled - Group 10 import_rules importing rules with an index should migrate legacy actions in existing rule if overwrite is set to true
[job] [logs] FTR Configs #22 / detection engine api security and spaces enabled - Group 10 import_rules importing rules with an index should migrate legacy actions in existing rule if overwrite is set to true
[job] [logs] FTR Configs #15 / detection engine api security and spaces enabled - Group 4 Detection rule type telemetry Detection rule telemetry "kql" rule type should show "notifications_disabled" to be "1" for rule that has at least "1" action(s) and the alert is "disabled"/"in-active"
[job] [logs] FTR Configs #15 / detection engine api security and spaces enabled - Group 4 Detection rule type telemetry Detection rule telemetry "kql" rule type should show "notifications_disabled" to be "1" for rule that has at least "1" action(s) and the alert is "disabled"/"in-active"
[job] [logs] FTR Configs #41 / detection engine api security and spaces enabled - rule execution logic Query type rules with suppression enabled with a suppression time window should update an alert using real rule executions
[job] [logs] FTR Configs #41 / detection engine api security and spaces enabled - rule execution logic Query type rules with suppression enabled with a suppression time window should update an alert using real rule executions
[job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/date_numeric_types/configs/serverless.config.ts / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type date "is" operator should filter 1 single date if it is set as an exception
[job] [logs] FTR Configs #48 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type date "is" operator should filter 1 single date if it is set as an exception
[job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/date_numeric_types/configs/serverless.config.ts / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type date "is" operator should filter 1 single date if it is set as an exception
[job] [logs] FTR Configs #48 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type date "is" operator should filter 1 single date if it is set as an exception
[job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/configs/serverless.config.ts / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type keyword "is" operator should filter 1 single keyword if it is set as an exception
[job] [logs] FTR Configs #15 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type keyword "is" operator should filter 1 single keyword if it is set as an exception
[job] [logs] x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/configs/serverless.config.ts / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type keyword "is" operator should filter 1 single keyword if it is set as an exception
[job] [logs] FTR Configs #15 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type keyword "is" operator should filter 1 single keyword if it is set as an exception
[job] [logs] FTR Configs #3 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type text "is" operator should filter 1 single text if it is set as an exception
[job] [logs] FTR Configs #19 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type text "is" operator should filter 1 single text if it is set as an exception
[job] [logs] FTR Configs #19 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type text "is" operator should filter 1 single text if it is set as an exception
[job] [logs] FTR Configs #3 / Detection exceptions data types and operators @serverless @ess Rule exception operators for data type text "is" operator should filter 1 single text if it is set as an exception
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Add index patterns to custom rules Add index patterns to custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Add index patterns to custom rules Add index patterns to custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Delete all index patterns from custom rules Delete all index patterns from custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Delete all index patterns from custom rules Delete all index patterns from custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Delete index patterns from custom rules Delete index patterns from custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Delete index patterns from custom rules Delete index patterns from custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Display success toast after editing the index pattern Display success toast after editing the index pattern
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Display success toast after editing the index pattern Display success toast after editing the index pattern
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Index pattern action applied to custom rules, including machine learning: user proceeds with edit of custom non machine learning rule Index pattern action applied to custom rules, including machine learning: user proceeds with edit of custom non machine learning rule
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Index pattern action applied to custom rules, including machine learning: user proceeds with edit of custom non machine learning rule Index pattern action applied to custom rules, including machine learning: user proceeds with edit of custom non machine learning rule
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Overwrite index patterns in custom rules Overwrite index patterns in custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Index patterns Overwrite index patterns in custom rules Overwrite index patterns in custom rules
[job] [logs] Security Solution Cypress Tests #3 / Detection rules, bulk edit of rule actions All actions privileges "before each" hook for "Add a rule action to rules (existing connector)" "before each" hook for "Add a rule action to rules (existing connector)"
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detection rules, bulk edit of rule actions All actions privileges "before each" hook for "Add a rule action to rules (existing connector)" "before each" hook for "Add a rule action to rules (existing connector)"
[job] [logs] Security Solution Cypress Tests #3 / Detection rules, bulk edit of rule actions All actions privileges "before each" hook for "Add a rule action to rules (existing connector)" "before each" hook for "Add a rule action to rules (existing connector)"
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detection rules, bulk edit of rule actions All actions privileges "before each" hook for "Add a rule action to rules (existing connector)" "before each" hook for "Add a rule action to rules (existing connector)"
[job] [logs] Security Solution Cypress Tests #3 / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions User with no privileges can't add rule actions
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions User with no privileges can't add rule actions
[job] [logs] Security Solution Cypress Tests #3 / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions User with no privileges can't add rule actions
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions User with no privileges can't add rule actions
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Timeline templates Apply timeline template to custom rules Apply timeline template to custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Timeline templates Apply timeline template to custom rules Apply timeline template to custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Timeline templates Reset timeline template to None for custom rules Reset timeline template to None for custom rules
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Detection rules, bulk edit Timeline templates Reset timeline template to None for custom rules Reset timeline template to None for custom rules
[job] [logs] FTR Configs #75 / Discover alerting Search source Alert should navigate to alert results via view in app link
[job] [logs] FTR Configs #75 / Discover alerting Search source Alert should navigate to alert results via view in app link
[job] [logs] FTR Configs #36 / Exceptions API @serverless @ess create_endpoint_exceptions operating system types (os_types) endpoints should filter 1 operating system types (os_type) if it is set as part of an endpoint exception
[job] [logs] FTR Configs #49 / Exceptions API @serverless @ess create_endpoint_exceptions operating system types (os_types) endpoints should filter 1 operating system types (os_type) if it is set as part of an endpoint exception
[job] [logs] FTR Configs #49 / Exceptions API @serverless @ess create_endpoint_exceptions operating system types (os_types) endpoints should filter 1 operating system types (os_type) if it is set as part of an endpoint exception
[job] [logs] FTR Configs #36 / Exceptions API @serverless @ess create_endpoint_exceptions operating system types (os_types) endpoints should filter 1 operating system types (os_type) if it is set as part of an endpoint exception
[job] [logs] Security Solution Cypress Tests #9 / Exceptions match_any Creates exception item Creates exception item
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #1 / Exceptions match_any Creates exception item Creates exception item
[job] [logs] Security Solution Cypress Tests #9 / Exceptions match_any Creates exception item Creates exception item
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #1 / Exceptions match_any Creates exception item Creates exception item
[job] [logs] Jest Tests #18 / find() calls mapSortField
[job] [logs] Jest Tests #18 / find() calls saved objects client with given params
[job] [logs] Jest Tests #18 / find() finds rules with actions using preconfigured connectors
[job] [logs] Jest Tests #18 / find() finds rules with actions using system connectors
[job] [logs] FTR Configs #59 / Monitoring app Cluster listing Alerts should show a toast when alerts are created successfully
[job] [logs] FTR Configs #59 / Monitoring app Cluster listing Alerts should show a toast when alerts are created successfully
[job] [logs] FTR Configs #81 / Observability Rules Synthetics SyntheticsRules creates rule when settings are configured
[job] [logs] FTR Configs #81 / Observability Rules Synthetics SyntheticsRules creates rule when settings are configured
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Rule actions during detection rule creation Indexes a new document after the index action is triggered Indexes a new document after the index action is triggered
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Rule actions during detection rule creation Indexes a new document after the index action is triggered Indexes a new document after the index action is triggered
[job] [logs] FTR Configs #35 / Rule creation API @serverless @ess create_rules @brokenInServerless per-action frequencies actions without frequencies sets each action's frequency attribute to default value when 'throttle' is undefined
[job] [logs] FTR Configs #35 / Rule creation API @serverless @ess create_rules @brokenInServerless per-action frequencies actions without frequencies sets each action's frequency attribute to default value when 'throttle' is undefined
[job] [logs] Security Solution Cypress Tests #8 / rule snoozing Rule editing page / actions tab adds an action to a snoozed rule adds an action to a snoozed rule
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / rule snoozing Rule editing page / actions tab adds an action to a snoozed rule adds an action to a snoozed rule
[job] [logs] Security Solution Cypress Tests #8 / rule snoozing Rule editing page / actions tab adds an action to a snoozed rule adds an action to a snoozed rule
[job] [logs] Serverless Security Cypress Tests #1 / rule snoozing Rule editing page / actions tab adds an action to a snoozed rule adds an action to a snoozed rule
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / rule snoozing Rule editing page / actions tab adds an action to a snoozed rule adds an action to a snoozed rule
[job] [logs] Security Solution Cypress Tests #8 / rule snoozing Rules management table snoozes a rule with actions for 2 days snoozes a rule with actions for 2 days
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / rule snoozing Rules management table snoozes a rule with actions for 2 days snoozes a rule with actions for 2 days
[job] [logs] Security Solution Cypress Tests #8 / rule snoozing Rules management table snoozes a rule with actions for 2 days snoozes a rule with actions for 2 days
[job] [logs] Serverless Security Cypress Tests #1 / rule snoozing Rules management table snoozes a rule with actions for 2 days snoozes a rule with actions for 2 days
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / rule snoozing Rules management table snoozes a rule with actions for 2 days snoozes a rule with actions for 2 days
[job] [logs] FTR Configs #57 / serverless search UI Rule details Edit rule with deleted connector should show and update deleted connectors when there are existing connectors of the same type
[job] [logs] FTR Configs #57 / serverless search UI Rule details Edit rule with deleted connector should show and update deleted connectors when there are existing connectors of the same type
[job] [logs] Jest Tests #18 / update() calls the authentication API key function if the user is authenticated using an api key
[job] [logs] Jest Tests #18 / update() calls the createApiKey function
[job] [logs] Jest Tests #18 / update() doesn't call the createAPIKey function when alert is disabled
[job] [logs] Jest Tests #18 / update() logs warning when creating with an interval less than the minimum configured one when enforce = false
[job] [logs] Jest Tests #18 / update() should call useSavedObjectReferences.extractReferences and useSavedObjectReferences.injectReferences if defined for rule type
[job] [logs] Jest Tests #18 / update() should trim alert name in the API key name
[job] [logs] Jest Tests #18 / update() should update a rule even if action is missing secret when allowMissingConnectorSecrets is true
[job] [logs] Jest Tests #18 / update() should update a rule with some preconfigured actions
[job] [logs] Jest Tests #18 / update() should update a rule with some system actions
[job] [logs] Jest Tests #18 / update() swallows error when getDecryptedAsInternalUser throws
[job] [logs] Jest Tests #18 / update() swallows error when invalidate API key throws
[job] [logs] Jest Tests #18 / update() updates an action with uuid and adds uuid to an action without it
[job] [logs] Jest Tests #18 / update() updates given parameters
[job] [logs] Jest Tests #18 / update() updating an alert schedule logs when update of schedule of an alerts underlying task fails
[job] [logs] Jest Tests #18 / update() updating an alert schedule updating the alert schedule should call taskManager.bulkUpdateSchedules
[job] [logs] Jest Tests #18 / update() updating an alert schedule updating the alert without changing the schedule should not call taskManager.bulkUpdateSchedules

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [6105ee6]

History

💔 Build #174093 failed 1124408
💔 Build #173825 failed 63ab319

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

guskovaue added 8 commits October 31, 2023 13:49

system action in bulk disable api

e17d2a7

add unit tests

6237a7b

add system action to bulk enable api

9d9b15e

add unit tests

466afb4

fix unit tests

5f25772

Merge branch 'system_actions_mvp' into sa_bulk_enable_api

de3bb36

fix types after merge main according snooze schedule changes

7d3b6f5

system actions for bulk delete api

63ab319

guskovaue added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Nov 7, 2023

guskovaue self-assigned this Nov 7, 2023

get alert from raw types fix

1124408

guskovaue marked this pull request as ready for review November 8, 2023 08:53

guskovaue requested a review from a team as a code owner November 8, 2023 08:53

cnasikas mentioned this pull request Nov 8, 2023

[Actions] System actions #160367

Closed

15 tasks

guskovaue requested a review from XavierM November 8, 2023 20:42

XavierM reviewed Nov 9, 2023

View reviewed changes

x-pack/plugins/alerting/server/application/rule/methods/bulk_delete/bulk_delete_rules.test.ts Show resolved Hide resolved

XavierM reviewed Nov 9, 2023

View reviewed changes

x-pack/plugins/alerting/server/data/rule/types/rule_attributes.ts Outdated Show resolved Hide resolved

XavierM reviewed Nov 9, 2023

View reviewed changes

x-pack/plugins/alerting/server/rules_client/lib/get_alert_from_raw.ts Show resolved Hide resolved

XavierM reviewed Nov 9, 2023

View reviewed changes

XavierM approved these changes Nov 13, 2023

View reviewed changes

Merge branch 'system_actions_mvp' into sa_bulk_delete_api

c587b32

guskovaue merged commit d8a7569 into elastic:system_actions_mvp Nov 14, 2023
21 of 67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] System action in bulk delete #170741

[RAM] System action in bulk delete #170741

guskovaue commented Nov 7, 2023

elasticmachine commented Nov 8, 2023

XavierM Nov 9, 2023

guskovaue Nov 10, 2023

XavierM Nov 9, 2023

guskovaue Nov 10, 2023

XavierM Nov 13, 2023

kibana-ci commented Nov 14, 2023 •

edited

Loading

	return ruleDomain;
	return transformRuleDomainToRule<Params>(ruleDomain);

[RAM] System action in bulk delete #170741

[RAM] System action in bulk delete #170741

Conversation

guskovaue commented Nov 7, 2023

Summary

Checklist

elasticmachine commented Nov 8, 2023

XavierM Nov 9, 2023

Choose a reason for hiding this comment

guskovaue Nov 10, 2023

Choose a reason for hiding this comment

XavierM Nov 9, 2023

Choose a reason for hiding this comment

guskovaue Nov 10, 2023

Choose a reason for hiding this comment

XavierM Nov 13, 2023

Choose a reason for hiding this comment

kibana-ci commented Nov 14, 2023 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

History

kibana-ci commented Nov 14, 2023 •

edited

Loading