-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] split alerting api-integration group2 #171105
Merged
dmlemeshko
merged 6 commits into
elastic:main
from
dmlemeshko:ftr/split-alerting-api-group-2
Nov 16, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4a9f0f0
[ftr] split alerting api tests - group 2
dmlemeshko 116078b
skip failing test
dmlemeshko 5657c1a
Merge branch 'main' into ftr/split-alerting-api-group-2
dmlemeshko 0ca4f0b
Merge branch 'main' into ftr/split-alerting-api-group-2
dmlemeshko f0073fd
Merge branch 'main' into ftr/split-alerting-api-group-2
dmlemeshko 6c5a2ca
Merge branch 'main' into ftr/split-alerting-api-group-2
dmlemeshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
x-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { createTestConfig } from '../../common/config'; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default createTestConfig('security_and_spaces', { | ||
disabledPlugins: [], | ||
license: 'trial', | ||
ssl: true, | ||
enableActionsProxy: true, | ||
publicBaseUrl: true, | ||
testFiles: [require.resolve('./tests')], | ||
useDedicatedTaskRunner: true, | ||
}); |
19 changes: 19 additions & 0 deletions
19
...t/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { createTestConfig } from '../../common/config'; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default createTestConfig('security_and_spaces', { | ||
disabledPlugins: [], | ||
license: 'trial', | ||
ssl: true, | ||
enableActionsProxy: true, | ||
publicBaseUrl: true, | ||
testFiles: [require.resolve('./tests')], | ||
useDedicatedTaskRunner: false, | ||
}); |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
36 changes: 36 additions & 0 deletions
36
x-pack/test/alerting_api_integration/security_and_spaces/group4/tests/alerting/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { FtrProviderContext } from '../../../../common/ftr_provider_context'; | ||
import { setupSpacesAndUsers, tearDown } from '../../../setup'; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default function alertingTests({ loadTestFile, getService }: FtrProviderContext) { | ||
describe('Alerts', () => { | ||
describe('alerts', () => { | ||
before(async () => { | ||
await setupSpacesAndUsers(getService); | ||
}); | ||
|
||
after(async () => { | ||
await tearDown(getService); | ||
}); | ||
|
||
loadTestFile(require.resolve('./alerts')); | ||
loadTestFile(require.resolve('./event_log')); | ||
loadTestFile(require.resolve('./mustache_templates')); | ||
loadTestFile(require.resolve('./health')); | ||
loadTestFile(require.resolve('./excluded')); | ||
loadTestFile(require.resolve('./snooze')); | ||
loadTestFile(require.resolve('./unsnooze')); | ||
loadTestFile(require.resolve('./global_execution_log')); | ||
loadTestFile(require.resolve('./get_global_execution_kpi')); | ||
loadTestFile(require.resolve('./get_action_error_log')); | ||
loadTestFile(require.resolve('./get_rule_execution_kpi')); | ||
}); | ||
}); | ||
} |
File renamed without changes.
File renamed without changes.
File renamed without changes.
15 changes: 15 additions & 0 deletions
15
x-pack/test/alerting_api_integration/security_and_spaces/group4/tests/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { FtrProviderContext } from '../../../../common/ftr_provider_context'; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default function alertingApiIntegrationTests({ loadTestFile }: FtrProviderContext) { | ||
describe('alerting api integration security and spaces enabled - Group 4', function () { | ||
loadTestFile(require.resolve('./alerting')); | ||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XavierM looked at some blames, seems like this one was specifically not run for a while, but the "global" version got enabled at some point. Maybe add a comment to the file if we know we're not using it at the moment? Or maybe it was mistakenly not enabled?