Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spaces to Dashboard Listing Table #171223

Closed

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented Nov 14, 2023

Summary

Related #171461.

Adds the Spaces column to the Dashboard listing page to allow users to easily see and share their dashboards with other Spaces.

I made updates the TableListViewTable shared component to conditionally show the Spaces column. This will allow other applications such as Lens and Maps to also show the Spaces column on their listing pages. The content management mSearch developer example has also been updated to show how other applications could add the Spaces column.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 14, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #71 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] FTR Configs #71 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] FTR Configs #58 / EPM Endpoints EPM - list list api tests lists all limited packages from the registry
  • [job] [logs] FTR Configs #60 / management index management index templates get all should list all the index templates with the expected parameters
  • [job] [logs] FTR Configs #60 / management index management index templates get all should list all the index templates with the expected parameters

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [3e64193]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickpeihl
Copy link
Member Author

Closing this as priorities have shifted.

@nickpeihl nickpeihl closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants