[Dashboard] Add Dashboard title to browser tab title #171255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Feature:Dashboard
Heenawter
commented
Nov 14, 2023
src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
Outdated
Show resolved
Hide resolved
Heenawter
commented
Nov 15, 2023
Heenawter
force-pushed
the
fix-dashboard-tab-title_2023-11-14
branch
from
07e2ca2 to
401ff96
Compare
Heenawter
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
approved these changes
Nov 15, 2023
ThomThomson
reviewed
Nov 15, 2023
src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @Heenawter |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2023
Closes elastic#162800 ## Summary This PR re-adds dashboard titles to the browser tab title, which was accidentally removed as part of the [portable dashboards](elastic#144332) work. For example, if I'm on the sample Logs dashboard, the title of that dashboard will now be reflected in the tab title like it was prior to `v8.7.0`: | Before | After | |--------|--------| |  |  | The tab title should stay up-to-date with Dashboard title changes, as demonstrated in this video: https://github.com/elastic/kibana/assets/8698078/651fff50-70f7-46ff-af47-b274fe6b0a19 Note that this will **only apply** to dashboards in the dashboard app - dashboards outside of the dashboard app should not change the browser tab title, unless the consumer does this on their own. ### [Flaky Test Runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3987)  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6150f76)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2023
…#171454) # Backport This will backport the following commits from `main` to `8.11`: - [[Dashboard] Add Dashboard title to browser tab title (#171255)](#171255) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-11-16T23:23:22Z","message":"[Dashboard] Add Dashboard title to browser tab title (#171255)\n\nCloses https://github.com/elastic/kibana/issues/162800\r\n\r\n## Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab title, which was\r\naccidentally removed as part of the [portable\r\ndashboards](#144332) work. For\r\nexample, if I'm on the sample Logs dashboard, the title of that\r\ndashboard will now be reflected in the tab title like it was prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n\r\nThe tab title should stay up-to-date with Dashboard title changes, as\r\ndemonstrated in this video:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/8698078/651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote that this will **only apply** to dashboards in the dashboard app -\r\ndashboards outside of the dashboard app should not change the browser\r\ntab title, unless the consumer does this on their own.\r\n\r\n### [Flaky Test\r\nRunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3987)\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:high","backport:prev-minor","ci:cloud-deploy","v8.12.0"],"number":171255,"url":"https://github.com/elastic/kibana/pull/171255","mergeCommit":{"message":"[Dashboard] Add Dashboard title to browser tab title (#171255)\n\nCloses https://github.com/elastic/kibana/issues/162800\r\n\r\n## Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab title, which was\r\naccidentally removed as part of the [portable\r\ndashboards](#144332) work. For\r\nexample, if I'm on the sample Logs dashboard, the title of that\r\ndashboard will now be reflected in the tab title like it was prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n\r\nThe tab title should stay up-to-date with Dashboard title changes, as\r\ndemonstrated in this video:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/8698078/651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote that this will **only apply** to dashboards in the dashboard app -\r\ndashboards outside of the dashboard app should not change the browser\r\ntab title, unless the consumer does this on their own.\r\n\r\n### [Flaky Test\r\nRunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3987)\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171255","number":171255,"mergeCommit":{"message":"[Dashboard] Add Dashboard title to browser tab title (#171255)\n\nCloses https://github.com/elastic/kibana/issues/162800\r\n\r\n## Summary\r\n\r\nThis PR re-adds dashboard titles to the browser tab title, which was\r\naccidentally removed as part of the [portable\r\ndashboards](#144332) work. For\r\nexample, if I'm on the sample Logs dashboard, the title of that\r\ndashboard will now be reflected in the tab title like it was prior to\r\n`v8.7.0`:\r\n\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n\r\nThe tab title should stay up-to-date with Dashboard title changes, as\r\ndemonstrated in this video:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/8698078/651fff50-70f7-46ff-af47-b274fe6b0a19\r\n\r\n\r\n\r\n\r\nNote that this will **only apply** to dashboards in the dashboard app -\r\ndashboards outside of the dashboard app should not change the browser\r\ntab title, unless the consumer does this on their own.\r\n\r\n### [Flaky Test\r\nRunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3987)\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6150f76abae664856a976bc230b9e90dbd844621"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162800
Summary
This PR re-adds dashboard titles to the browser tab title, which was accidentally removed as part of the portable dashboards work. For example, if I'm on the sample Logs dashboard, the title of that dashboard will now be reflected in the tab title like it was prior to
v8.7.0:The tab title should stay up-to-date with Dashboard title changes, as demonstrated in this video:
Screen.Recording.2023-11-15.at.8.43.40.AM.mov
Note that this will only apply to dashboards in the dashboard app - dashboards outside of the dashboard app should not change the browser tab title, unless the consumer does this on their own.
Flaky Test Runner
Checklist
For maintainers