-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] making service_token an output secret #171875
[Fleet] making service_token an output secret #171875
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core changes LGTM on the basis that service_token.id
is going to be used in search.
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + tests LGTM 🚀
Hi @elastic/platform-docs team, it looks like you are code owners, could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
FYI, the SO mapping addition done is this PR was done incorrectly. A new model version should have been added at the same time. I will fix it in #172056 |
Thanks for fixing! |
Summary
Related to #104986
Making remote ES output's service_token a secret.
fleet-server change here: elastic/fleet-server#3051 (comment)
Steps to verify:
kibana.dev.yml
locally:Checklist