Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] making service_token an output secret #171875

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Nov 23, 2023

Summary

Related to #104986

Making remote ES output's service_token a secret.

fleet-server change here: elastic/fleet-server#3051 (comment)

Steps to verify:

  • Enable remote ES output and output secrets in kibana.dev.yml locally:
xpack.fleet.enableExperimental: ['remoteESOutput', 'outputSecretsStorage']
GET .kibana_ingest/_search?q=type:ingest-outputs
  • Verify that the enrolled agent sends data to the remote ES successfully
image image

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Nov 23, 2023
@juliaElastic juliaElastic self-assigned this Nov 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@juliaElastic juliaElastic marked this pull request as ready for review November 27, 2023 14:15
@juliaElastic juliaElastic requested review from a team as code owners November 27, 2023 14:15
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM on the basis that service_token.id is going to be used in search.

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet self-requested a review November 27, 2023 16:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +885.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + tests LGTM 🚀

@juliaElastic
Copy link
Contributor Author

Hi @elastic/platform-docs team, it looks like you are code owners, could you review please?

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaElastic juliaElastic merged commit 517c815 into elastic:main Nov 28, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 28, 2023
@pgayvallet
Copy link
Contributor

FYI, the SO mapping addition done is this PR was done incorrectly. A new model version should have been added at the same time.

I will fix it in #172056

@juliaElastic
Copy link
Contributor Author

FYI, the SO mapping addition done is this PR was done incorrectly. A new model version should have been added at the same time.

I will fix it in #172056

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants