Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] enable feature flags #172464

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Dec 4, 2023

Summary

Closes #104986

Enable feature flags for remoteESOutput and outputSecretsStorage.

The feature is ready when #172181 and elastic/fleet-server#3127 is merged.

Output secret storage issues are closed, so I think the feature flag for that should be enabled too. cc @jillguyonnet

@juliaElastic juliaElastic self-assigned this Dec 4, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner December 4, 2023 13:06
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Dec 4, 2023
@juliaElastic
Copy link
Contributor Author

We might have a bug with secret field validation, one of the cypress tests failed with password field not being required:
image
I'll raise an issue for this.
cc @jillguyonnet

@kpollich
Copy link
Member

kpollich commented Dec 4, 2023

Check the logs for failed to decrypt password - there may be an issue with the AAD generated for the output objects. I had to explicitly exclude preset in my PR to fix a similar cypress failure.

(edit) This might be a different error but I just fixed Cypress issues on the same form so it's on my mind 🙂

@juliaElastic
Copy link
Contributor Author

Check the logs for failed to decrypt password - there may be an issue with the AAD generated for the output objects. I had to explicitly exclude preset in my PR to fix a similar cypress failure.

(edit) This might be a different error but I just fixed Cypress issues on the same form so it's on my mind 🙂

I think this is a different issue, enabling the output secrets feature flag changes how the kafka output field is rendered on the UI.

@nchaulet
Copy link
Member

nchaulet commented Dec 4, 2023

I think this is a different issue, enabling the output secrets feature flag changes how the kafka output field is rendered on the UI.

we should probably exclude secrets from the AAD otherwise any change to that field will make that output non decryptable.

@juliaElastic
Copy link
Contributor Author

we should probably exclude secrets from the AAD otherwise any change to that field will make that output non decryptable.

Good point, excluded secrets from AAD in outputs SO type.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 9d81996 into elastic:main Dec 5, 2023
31 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Support for Remote Elasticsearch cluster
7 participants