[Fleet] Fix preconfigured remote ES outputs with secrets

[jillguyonnet]

Summary

Closes #172546

Testing

1. Add the following to your Kibana config file and start Kibana:

xpack.fleet.outputs:
  - id: my-remote-es-output-with-a-secret
    name: preconfigured remote elasticsearch output with a secret
    type: remote_elasticsearch
    hosts: ['http://localhost:9997']
    secrets:
      service_token: secretRemoteESServiceToken

2. Head to Fleet UI and check that the output was correctly created.
3. Go to the Dev Tools Console and query Fleet secrets: GET .fleet-secrets/_search. Check that the service token secret was created.
4. Edit the output configuration, e.g. the value of the service token, and wait for Kibana to restart.
5. Check that the value(s) have been correctly updated.

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[juliaElastic]

LGTM, should we add a testcase for updating a remote es preconfig and comparing the secret with hashes?

[jillguyonnet]

Hey @juliaElastic I added the fix for remote ES output update (was broken, as discussed on Slack). I agree that unit tests should ideally be amended as they failed to pick that up (even though they did exist for remote ES outputs).

[juliaElastic]

Hey @juliaElastic I added the fix for remote ES output update (was broken, as discussed on Slack). I agree that unit tests should ideally be amended as they failed to pick that up (even though they did exist for remote ES outputs).

Thanks for fixing!

[jillguyonnet]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 0bad3ac

Metrics [docs]

✅ unchanged

History

• 💔 Build #181737 failed 7e82b17
• 💔 Build #181691 failed 3583765

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jillguyonnet