Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting/API Tests] Add await to objectRemover.removeAll() #172621

Merged

Conversation

tsullivan
Copy link
Member

Summary

Resolves an "unhandled Promise rejection" found for a CI failure for a PR: https://buildkite.com/elastic/kibana-pull-request/builds/181932#018c3b27-e511-4678-9e18-50f90e02c934


2023-12-05 19:03:36 UTC | Unhandled Promise rejection detected:
-- | --
  | 2023-12-05 19:03:36 UTC |  
  | 2023-12-05 19:03:36 UTC | Error: expected 204 "No Content", got 404 "Not Found"
  | 2023-12-05 19:03:36 UTC | at map (object_remover.ts:44:12)
  | 2023-12-05 19:03:36 UTC | at Array.map (<anonymous>)
  | 2023-12-05 19:03:36 UTC | at ObjectRemover.removeAll (object_remover.ts:38:28)
  | 2023-12-05 19:03:36 UTC | at Context.apply (max_queued_actions_circuit_breaker.ts:29:21)
  | 2023-12-05 19:03:36 UTC | at Object.apply (wrap_function.js:73:30)
  | 2023-12-05 19:03:36 UTC | at processTicksAndRejections (node:internal/process/task_queues:95:5)

@tsullivan tsullivan requested a review from a team as a code owner December 5, 2023 19:21
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Dec 5, 2023
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing!

@tsullivan tsullivan enabled auto-merge (squash) December 5, 2023 19:55
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Detection Engine - Security Solution Cypress Tests #6 / Alert user assignment - ESS & Serverless Updating assignees (single alert) adding new assignees via More actions in alerts table adding new assignees via More actions in alerts table
  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #1 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 94bb21e into elastic:main Dec 5, 2023
39 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 5, 2023
@tsullivan tsullivan deleted the alerting-tests/add-await-to-removeAll branch December 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants