Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [SLO] Reset UI for updating outdated SLOs (#172883) #173200

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR is a follow up to elastic#172224, it adds a UI for resetting the SLO
definitions from the previous model. Once elastic#179473 is merged I will
rebase this against `main` and convert it from a "draft" PR to "ready to
review".

![image](https://github.com/elastic/kibana/assets/41702/daf0591c-272f-40c2-9831-658d7b9b1378)

![image](https://github.com/elastic/kibana/assets/41702/d385396d-d840-4574-942a-b8e51ce66066)

![image](https://github.com/elastic/kibana/assets/41702/729df2a0-61e6-41b3-aaa5-8501e7aa7797)

### Testing

1. Start by loading `main`
2. Ingest some data
3. Create some SLOs
4. Change Kibana from `main` to this PR
5. Visit the SLO page, you should see a banner similar to the screen
shot above.
6. Do your best to break this

---------

Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
(cherry picked from commit c2003d9)
@kibanamachine kibanamachine enabled auto-merge (squash) December 12, 2023 19:42
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit 5716fb9 into elastic:8.12 Dec 13, 2023
42 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 567 573 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +8.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 102.8KB 102.9KB +100.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @simianhacker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants