[APM] Add memoization to hooks consumed on service inventory page #173973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
changed the title
sorenlouv
changed the title
sorenlouv
force-pushed
the
memoize-service-inventory
branch
from
07ed790
to
5d2f4df
Compare
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
mykolaharmash
approved these changes
Jan 2, 2024
sorenlouv
force-pushed
the
memoize-service-inventory
branch
from
5d2f4df
to
667aef3
Compare
sorenlouv
commented
Jan 5, 2024
| return router.getParams(...args, location, optional); | ||
| // it is not possible to statically verify the dependencies when spreading args. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [router, ...args, location, optional]); |
There was a problem hiding this comment.
@dgieselaar I need a review from the knowledge team apparently. Mind taking a look? Thanks
|
@elastic/obs-ux-management-team Looks like I need a review from you (no idea why really). Thanks! |
sorenlouv
force-pushed
the
memoize-service-inventory
branch
from
f9cc397
to
453e6cb
Compare
sorenlouv
force-pushed
the
memoize-service-inventory
branch
from
453e6cb
to
9c7bd09
Compare
dgieselaar
approved these changes
Jan 12, 2024
maryam-saeidi
approved these changes
Jan 12, 2024
sorenlouv
force-pushed
the
memoize-service-inventory
branch
2 times, most recently
from
3f7de21
to
a11e7ca
Compare
Avoid re-formatting Fix useBreakpoints [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
sorenlouv
force-pushed
the
memoize-service-inventory
branch
from
a11e7ca
to
3ba0e3d
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
cauemarcondes
added a commit
that referenced
this pull request
Jan 30, 2024
Closes: #127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - #173973 - #174746 - #174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This perf optimisation is needed for improvements made on the Service Inventory page. The memoisations should improve perf of any component currently consuming them.
Related: #127036