Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] Replace deprecated node-sass with sass #2 (#173942) #174034

Closed

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

## Summary

The previous PR elastic#161813 was
reverted due to the broken webpack config

elastic@eef1afc

---------

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
(cherry picked from commit d4be2a3)
@jbudz jbudz disabled auto-merge December 28, 2023 16:45
@jbudz jbudz closed this Dec 28, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams "after all" hook in "with installed integrations and uncategorized data streams"
  • [job] [logs] FTR Configs #13 / Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams "before all" hook in "with installed integrations and uncategorized data streams"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.9KB 1013.9KB -2.0B
cloudSecurityPosture 443.8KB 443.8KB +12.0B
controls 198.4KB 198.4KB -6.0B
dashboard 377.3KB 377.3KB +4.0B
dataViewManagement 120.0KB 120.0KB -2.0B
dataVisualizer 618.6KB 618.6KB +10.0B
discover 590.3KB 590.3KB +14.0B
enterpriseSearch 2.7MB 2.7MB -52.0B
eventAnnotationListing 196.9KB 197.0KB +16.0B
filesManagement 89.9KB 89.9KB -4.0B
graph 388.2KB 388.2KB +8.0B
home 178.6KB 178.6KB -14.0B
indexManagement 585.2KB 585.2KB +6.0B
infra 1.9MB 1.9MB -4.0B
ingestPipelines 360.8KB 360.8KB -4.0B
kibanaOverview 46.6KB 46.6KB -4.0B
kibanaReact 214.5KB 214.7KB +194.0B
lens 1.4MB 1.4MB +4.0B
management 75.2KB 75.2KB -4.0B
maps 2.9MB 2.9MB +36.0B
metricsDataAccess 85.2KB 85.2KB -4.0B
ml 3.6MB 3.6MB +28.0B
monitoring 462.5KB 462.6KB +66.0B
observabilityShared 36.3KB 36.3KB -4.0B
osquery 1.0MB 1.0MB -4.0B
presentationUtil 82.5KB 82.5KB +10.0B
security 569.6KB 569.7KB +16.0B
securitySolution 13.1MB 13.1MB +2.0B
securitySolutionEss 42.7KB 42.7KB -4.0B
securitySolutionServerless 361.1KB 361.1KB -4.0B
spaces 174.9KB 174.9KB -4.0B
stackAlerts 80.7KB 80.7KB +10.0B
unifiedDocViewer 58.5KB 58.5KB +6.0B
unifiedSearch 215.9KB 215.9KB +8.0B
visDefaultEditor 141.0KB 141.0KB -14.0B
visTypeTimelion 38.8KB 38.8KB -4.0B
visTypeVega 1.8MB 1.8MB -4.0B
visTypeVislib 339.7KB 339.7KB +40.0B
visualizations 268.3KB 268.3KB -28.0B
total +320.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 375.2KB 375.3KB +76.0B
embeddable 78.7KB 78.7KB +20.0B
esUiShared 155.9KB 155.9KB -4.0B
globalSearchBar 26.3KB 26.3KB -6.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +280.0B
kibanaOverview 15.2KB 15.1KB -24.0B
kibanaReact 42.2KB 42.2KB -6.0B
osquery 51.3KB 51.3KB +10.0B
searchprofiler 18.7KB 18.8KB +18.0B
total +364.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants