[Fleet] make deprecated paths public #175038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
approved these changes
Jan 17, 2024
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 18, 2024
## Summary Closes elastic#175031 Made deprecated APIs public instead of internal, to fix the accidental breaking change for customers who called these APIs before (internal APIs don't have a default version resolution yet, so require a version header) One caveat of this change is if someone already changed their deprecated API call to use 'elastic-api-version: 1' in 8.11, as it would have to be changed again to use the public version or remove the header. Though I don't think we have many usages like that, since the version usage is not very well documented and we only got one support question about it. (cherry picked from commit e31118a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jan 22, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] make deprecated paths public (#175038)](#175038) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-18T14:35:56Z","message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.1","v8.13.0"],"title":"[Fleet] make deprecated paths public","number":175038,"url":"https://github.com/elastic/kibana/pull/175038","mergeCommit":{"message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175038","number":175038,"mergeCommit":{"message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5"}}]}] BACKPORT--> --------- Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> Co-authored-by: Julia Bardi <julia.bardi@elastic.co>
kibanamachine
removed
the
backport missing
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Closes elastic#175031 Made deprecated APIs public instead of internal, to fix the accidental breaking change for customers who called these APIs before (internal APIs don't have a default version resolution yet, so require a version header) One caveat of this change is if someone already changed their deprecated API call to use 'elastic-api-version: 1' in 8.11, as it would have to be changed again to use the public version or remove the header. Though I don't think we have many usages like that, since the version usage is not very well documented and we only got one support question about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #175031
Made deprecated APIs public instead of internal, to fix the accidental breaking change for customers who called these APIs before (internal APIs don't have a default version resolution yet, so require a version header)
One caveat of this change is if someone already changed their deprecated API call to use 'elastic-api-version: 1' in 8.11, as it would have to be changed again to use the public version or remove the header. Though I don't think we have many usages like that, since the version usage is not very well documented and we only got one support question about it.