Fixes issue #1658: Field formatter trying to apply missing formatter #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| .attr('fill', function (d) { | ||
| return color(d.label); | ||
| }); | ||
|
|
There was a problem hiding this comment.
The added indentation here seems inconsistent with how it is applied elsewhere in the code. Was this an intentional change?
There was a problem hiding this comment.
@rashidkpc Nope, sometimes my editor adds indents automatically. Fixing.
|
Other than that minor nitpick, this LGTM |
rashidkpc
added a commit
that referenced
this pull request
Oct 28, 2014
Fixes issue #1658: Field formatter trying to apply missing formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests closes #1658.
The code that used the
fieldformat functions from therawobject has been removed. Fixing the current bug will cause values in the legend for Bar, Line, and Area charts to be broken for time values. Instead of displaying human readable date formats, timestamps will be displayed instead. We will need to refactor thehistogramdata converter to send either label formatters or change the currentxAxisFormatterto make it more general for any value type. For more details, see my comments in #1658.I have also updated the formatters for the pie chart. The pie chart data converter sends field formatters for all of its data values, which means the pie legend values will be formatted appropriately.