Upgrade EUI to v93.1.1 #176762

cee-chen · 2024-02-12T21:11:07Z

v93.0.0 ⏩ v93.1.1

`v93.1.1`

This is a patch release primarily intended for use by Kibana.

Added top-level EuiTreeView.Item export (#7526)

`v93.1.0`

Added index glyph to EuiIcon (#7498)
Updated EuiHighlight to accept an array of search strings, which allows highlighting multiple, separate words within its children. This new type and behavior only works if highlightAll is also set to true. (#7496)
Updated EuiContextMenu with a new panels.items.renderItem property, which allows rendering completely custom items next to standard EuiContextMenuItem objects (#7510)
EuiSuperDatePicker updates:
- Updated EuiSuperDatePicker with a new refreshIntervalUnits prop. Passing this prop allows controlling and overriding the default unit rounding behavior. (#7501)
- Updated EuiAutoRefresh and EuiRefreshInterval with a new intervalUnits prop. Passing this prop allows controlling and overriding the default unit rounding behavior. (#7501)
- Updated onRefreshChange to pass back a new intervalUnits key that contains the current interval unit format (seconds, minutes, or hours). (#7501)
- Updated EuiSuperDatePicker with a new canRoundRelativeUnits prop, which defaults to true (current behavior). To preserve displaying the unit that users select for relative time, set this to false. (#7502)
- Updated EuiSuperDatePicker with a new refreshMinInterval prop, which accepts a minimum number in milliseconds (#7516)
- Updated EuiAutoRefresh and EuiRefreshInterval with a new minInterval prop, which accepts a minimum number in milliseconds (#7516)

Bug fixes

Fixed EuiHighlight to not parse search strings as regexes (#7496)
Fixed EuiSuperDatePicker submit bug when used within <form> elements (#7504)
Fixed an EuiTreeView bug where aria-expanded was being applied to items without expandable children (#7513)

CSS-in-JS conversions

Converted EuiTreeView to Emotion. Updates as part of the conversion: (#7513)
- Removed .euiTreeView__wrapper div node
- Enforced consistent icon size based on display size

cee-chen · 2024-02-13T16:42:49Z

...lugins/kubernetes_security/public/components/tree_view_container/dynamic_tree_view/index.tsx

@opauloh Please feel free to pull down and QA this component locally. I'm fairly sure with the local data given that this still looks/works as expected, but would appreciate someone more familiar with production end-usage testing it!

Hi @cee-chen

Tested the Kubernetes TreeView with more data and the functionality looks good. There are two clusters with data from other integrations and it now shows the no data available message, thanks for adding that!

I only found one bug, when there were a lot of nested children it gets oddly positioned among the other elements of the tree, here's the screen recording:

Screen.Recording.2024-02-15.at.4.28.21.PM.mov

Tried to quickly figure out what was possibly causing the issue, looks like there's a max block size set to 100vh, and removing it seems to fix the issue.

Screen.Recording.2024-02-15.at.4.29.02.PM.mov

@opauloh 100vh override was pushed up in 740a1fb, let me know if that fixes the issue for you!

elasticmachine · 2024-02-13T20:43:17Z

Pinging @elastic/eui-team (EUI)

elasticmachine · 2024-02-13T21:27:08Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

cauemarcondes

APM LGTM

- also removed in EUI and doesn't really enhance SR experience (reviewed by a11y engineer)

…ation - remove usages of EUI classNames, which no longer have any attached styles - clean up/as many unecessary styles as possible in favor of using component instead + clean up loading UI in favor of using existing `icon` props on components

- put the `onKeyDown` on the text wrapper instead, since that already exists

- have a single expand/select action instead, which is more correct from an a11y perspective

…ems with arrow toggles but no children + remove hover/focus state for loading & empy messages

kibana-ci · 2024-02-19T07:37:50Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 740a1fb

Failed CI Steps

Investigations - Security Solution Cypress Tests #6

Test Failures

[job] [logs] Investigations - Security Solution Cypress Tests #6 / Basic esql search and filter operations "before each" hook for "should remove the query when the back button is pressed after adding a query" "before each" hook for "should remove the query when the back button is pressed after adding a query"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`kubernetesSecurity`	60	198	+138

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.7MB	2.7MB	-1.0B
`kubernetesSecurity`	38.6KB	205.1KB	+166.6KB
`maps`	2.9MB	2.9MB	-1.0B
`serverlessSearch`	426.8KB	426.7KB	-1.0B
total			+166.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	384.6KB	384.4KB	-185.0B
`kbnUiSharedDeps-css`	282.1KB	280.1KB	-2.0KB
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	+6.0KB
`kubernetesSecurity`	5.8KB	6.0KB	+213.0B
total			+4.1KB

History

💚 Build #193954 succeeded 68547a85dbda2ef3ddeac8ff4aab9d45efcc89d1
💔 Build #193889 failed 715e42aa845678674ef9b8d08cca49a72291d6d0
💚 Build #193424 succeeded eb0fc7131c677699bdd8d4b28f186b00ef751ec5
💚 Build #193172 succeeded 0f0b282fd9713f16fbb40d5bd84066b702b85550
💛 Build #193167 was flaky b5b968fce7f14e78cc7e5be6cc008eebad307748
💔 Build #193137 failed ddb655a2c535da1413b943f03ea13ecc859669ea

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

opauloh

LGTM 🚀 thanks @cee-chen !

`v93.0.0` ⏩ `v93.1.1` --- ## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0) **This is a patch release primarily intended for use by Kibana.** - Added top-level `EuiTreeView.Item` export ([elastic#7526](elastic/eui#7526)) ## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0) - Added `index` glyph to `EuiIcon` ([elastic#7498](elastic/eui#7498)) - Updated `EuiHighlight` to accept an array of `search` strings, which allows highlighting multiple, separate words within its children. This new type and behavior *only* works if `highlightAll` is also set to true. ([elastic#7496](elastic/eui#7496)) - Updated `EuiContextMenu` with a new `panels.items.renderItem` property, which allows rendering completely custom items next to standard `EuiContextMenuItem` objects ([elastic#7510](elastic/eui#7510)) - `EuiSuperDatePicker` updates: - Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([elastic#7501](elastic/eui#7501)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `intervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([elastic#7501](elastic/eui#7501)) - Updated `onRefreshChange` to pass back a new `intervalUnits` key that contains the current interval unit format (seconds, minutes, or hours). ([elastic#7501](elastic/eui#7501)) - Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop, which defaults to true (current behavior). To preserve displaying the unit that users select for relative time, set this to false. ([elastic#7502](elastic/eui#7502)) - Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop, which accepts a minimum number in milliseconds ([elastic#7516](elastic/eui#7516)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `minInterval` prop, which accepts a minimum number in milliseconds ([elastic#7516](elastic/eui#7516)) **Bug fixes** - Fixed `EuiHighlight` to not parse `search` strings as regexes ([elastic#7496](elastic/eui#7496)) - Fixed `EuiSuperDatePicker` submit bug when used within `<form>` elements ([elastic#7504](elastic/eui#7504)) - Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to items without expandable children ([elastic#7513](elastic/eui#7513)) **CSS-in-JS conversions** - Converted `EuiTreeView` to Emotion. Updates as part of the conversion: ([elastic#7513](elastic/eui#7513)) - Removed `.euiTreeView__wrapper` div node - Enforced consistent `icon` size based on `display` size

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.14.0 labels Feb 12, 2024

cee-chen force-pushed the eui/v93.1.0 branch 4 times, most recently from 0f0b282 to a9f7324 Compare February 13, 2024 16:38

cee-chen commented Feb 13, 2024

View reviewed changes

cee-chen marked this pull request as ready for review February 13, 2024 20:43

cee-chen requested review from a team as code owners February 13, 2024 20:43

Ikuni17 approved these changes Feb 13, 2024

View reviewed changes

botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Feb 13, 2024

cauemarcondes approved these changes Feb 14, 2024

View reviewed changes

jloleysens approved these changes Feb 14, 2024

View reviewed changes

cee-chen added 9 commits February 18, 2024 22:13

Upgrade EUI to v93.1.1

4536e03

i18n updates

a5c805c

[EuiSuperDatePicker] Update usage of onRefreshChange type

48c7cd8

[EuiTreeView][Security] Remove aria-labels

f2a1999

- also removed in EUI and doesn't really enhance SR experience (reviewed by a11y engineer)

[EuiTreeView][Security] Remove unnecessary extra <div> wrapper

5585409

- put the `onKeyDown` on the text wrapper instead, since that already exists

[EuiTreeView][Security] Fix/remove arrow toggle behavior

53b81ca

- have a single expand/select action instead, which is more correct from an a11y perspective

[Kubernetes Security] Add empty message to reduce confusion around it…

7f3a503

…ems with arrow toggles but no children + remove hover/focus state for loading & empy messages

[EuiTreeView][PR feedback] Fix visual bug with lots of nested children

740a1fb

cee-chen force-pushed the eui/v93.1.0 branch from c09b006 to 740a1fb Compare February 19, 2024 06:13

opauloh approved these changes Feb 20, 2024

View reviewed changes

cee-chen merged commit 2680755 into elastic:main Feb 20, 2024
35 checks passed

cee-chen deleted the eui/v93.1.0 branch February 20, 2024 17:29

kibanamachine added the backport:skip This commit does not require backporting label Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v93.1.1 #176762

Upgrade EUI to v93.1.1 #176762

cee-chen commented Feb 12, 2024 •

edited

Loading

cee-chen Feb 13, 2024

opauloh Feb 16, 2024

cee-chen Feb 19, 2024

elasticmachine commented Feb 13, 2024

elasticmachine commented Feb 13, 2024

cauemarcondes left a comment

kibana-ci commented Feb 19, 2024

opauloh left a comment

Upgrade EUI to v93.1.1 #176762

Upgrade EUI to v93.1.1 #176762

Conversation

cee-chen commented Feb 12, 2024 • edited Loading

v93.1.1

v93.1.0

cee-chen Feb 13, 2024

Choose a reason for hiding this comment

opauloh Feb 16, 2024

Choose a reason for hiding this comment

cee-chen Feb 19, 2024

Choose a reason for hiding this comment

elasticmachine commented Feb 13, 2024

elasticmachine commented Feb 13, 2024

cauemarcondes left a comment

Choose a reason for hiding this comment

kibana-ci commented Feb 19, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

opauloh left a comment

Choose a reason for hiding this comment

cee-chen commented Feb 12, 2024 •

edited

Loading

`v93.1.1`

`v93.1.0`