Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace KuiCard with EuiCard in kibana home #17771

Merged
merged 4 commits into from
May 1, 2018
Merged

replace KuiCard with EuiCard in kibana home #17771

merged 4 commits into from
May 1, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 18, 2018 •
edited
Loading

replace KuiCard with EuiCard in kibana home

@nreese nreese added WIP Work in progress :Sharing labels Apr 18, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese mentioned this pull request Apr 25, 2018
Merged
@nreese nreese added the chore label Apr 25, 2018
@nreese nreese removed the WIP Work in progress label Apr 27, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon
Copy link
Contributor

Looks like the breaks on window sizes changed a bit with this.

Before:

screen shot 2018-04-30 at 8 14 53 am

After:
screen shot 2018-04-30 at 8 12 25 am

@nreese
Copy link
Contributor Author

nreese commented Apr 30, 2018

@stacey-gammon I pushed a change that now sets the wrap property on the FlexGroup. That will allow the cards to wrap on smaller screens

stacey-gammon
stacey-gammon approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

chrisdavies
chrisdavies approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nreese nreese merged commit bb7e0b2 into elastic:master May 1, 2018
@nreese nreese mentioned this pull request May 1, 2018
Merged
nreese added a commit to nreese/kibana that referenced this pull request May 1, 2018
@nreese
replace KuiCard with EuiCard in kibana home (elastic#17771)
5fdc27c 
* replace KuiCard with EuiCard in kibana home

* fix button styling

* update snapshots caused by new EUI version from rebase

* allow flex group to wrap
nreese added a commit that referenced this pull request May 1, 2018
@nreese
replace KuiCard with EuiCard in kibana home (#17771) (#18695)
2dfd8b7 
* replace KuiCard with EuiCard in kibana home

* fix button styling

* update snapshots caused by new EUI version from rebase

* allow flex group to wrap
@nreese nreese deleted the euiCard branch July 18, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

@chrisdavies chrisdavies chrisdavies approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @stacey-gammon @chrisdavies