-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLO] Implement federated views #178050
[SLO] Implement federated views #178050
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
packages/kbn-server-route-repository/src/decode_request_params.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
x-pack/plugins/observability_solution/slo/public/utils/slo/get_discover_link.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/slo/public/utils/slo/remote_slo_urls.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/slo/server/services/slo_definition_client.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/slo/server/services/slo_settings.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/slo/server/services/summary_client.ts
Outdated
Show resolved
Hide resolved
Yeah I think we should redirect to the remote ideally. |
…tings/settings_form.tsx Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b702e46
to
d8bf376
Compare
@simianhacker Fixed d8bf376 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
Great work !!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Issue and documentation: https://github.com/elastic/observability-dev/issues/3045
Extra:
Closes #180194
🍒 Summary
This PR implements federated view, allowing a list of remote clusters to be used to fetch remote SLOs. These remote SLOs are shown on the SLO listing page next to the local SLOs.
Remote SLOs are fetched using the current space: Remote SLOs created on a specific space will only be displayed on the SLOs listing page of the same space in the overview cluster.
The SLO models evolved quite a bit recently, and our types were not representative anymore of this new model. I've introduced an
SLODefinition
type that represents an SLO when we define it and store it in the repository. And aSLOWithSummaryData
type (bad name because summary is not the only thing we have now) that includes things likeinstanceId
,groupings
,summary
andremote
data that we add to the SLO definition.🥼 Testing
Create an edge-lite-oblt cluster
Run
oblt-cli cluster create ccs --remote-cluster=edge-lite-oblt
Use the kibana.yml file provided by robots but add the server path:
Then run kibana locally normally:
yarn kbn bootstrap && yarn start
Generate data in your oblt cluster
Use the ES credentials from the robot notification:
Create SLOs on edge-lite-oblt cluster
Create some SLO on the edge-lite-oblt cluster directly.
📓 Scenario
💡 Use different SLI type
on remote cluster:
on local cluster:
Checklist
to be continued
📺 Features
🖼️ Screenshots
Follow-ups
📋 Tasks to wrap up
0
label on the alerts tab for the remote and disable the tab with a tooltip.