-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Remove Serverless plugin dependency #178165
[Discover] Remove Serverless plugin dependency #178165
Conversation
/ci |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @davismcphee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logs_explorer
changes LGTM 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design changes LGTM.
Summary
This PR removes the serverless plugin dependency from Discover and replaces it with a
showInlineTopNav
method on the Discover plugin contract, which gets called from within serverless project plugins to enable the serverless top nav. It also modifies theDiscoverCustomizationContext
and moves it to thecustomizations
folder, as well as consolidating customization context mocks, to help lay some groundwork for upcoming Discover extensions work.Checklist
For maintainers