Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Remove Serverless plugin dependency #178165

Merged

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Mar 6, 2024

Summary

This PR removes the serverless plugin dependency from Discover and replaces it with a showInlineTopNav method on the Discover plugin contract, which gets called from within serverless project plugins to enable the serverless top nav. It also modifies the DiscoverCustomizationContext and moves it to the customizations folder, as well as consolidating customization context mocks, to help lay some groundwork for upcoming Discover extensions work.

Checklist

For maintainers

@davismcphee davismcphee added the release_note:skip Skip the PR/issue when compiling release notes label Mar 6, 2024
@davismcphee davismcphee self-assigned this Mar 6, 2024
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests on Serverless #10 / User Roles for Security Complete PLI with Endpoint Complete addon for role: endpoint_operations_analyst should have access to response action: suspend-process should have access to response action: suspend-process

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 109 110 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 581.3KB 581.5KB +147.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 33.2KB 33.3KB +59.0B
observabilityLogsExplorer 15.3KB 15.2KB -52.0B
securitySolutionServerless 35.9KB 36.0KB +30.0B
serverlessObservability 26.6KB 26.6KB +55.0B
serverlessSearch 19.3KB 19.3KB +30.0B
total +122.0B
Unknown metric groups

API count

id before after diff
discover 157 158 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee marked this pull request as ready for review March 7, 2024 03:45
@davismcphee davismcphee requested review from a team as code owners March 7, 2024 03:45
@davismcphee davismcphee requested a review from a team March 7, 2024 03:45
@davismcphee davismcphee requested review from a team as code owners March 7, 2024 03:45
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs_explorer changes LGTM 👌

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM

Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design changes LGTM.

@davismcphee davismcphee merged commit 20aa335 into elastic:main Mar 7, 2024
38 checks passed
@davismcphee davismcphee deleted the discover-remove-serverless-dependency branch March 7, 2024 17:30
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.