-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps: Adds Pattern analysis tab in Discover #178916
[ML] AIOps: Adds Pattern analysis tab in Discover #178916
Conversation
/ci |
/ci |
/ci |
Tested latest changes and ML-changes LGTM. Please feel free to merge this one ahead of the ES|QL field stats in Discover PR 👍 . I'll wait to merge it after this one is in. |
import { METRIC_TYPE, UiCounterMetricType } from '@kbn/analytics'; | ||
import { type EmbeddablePatternAnalysisInput } from '@kbn/aiops-log-pattern-analysis/embeddable'; | ||
import { pick } from 'lodash'; | ||
import { LogCategorizationEmbeddableProps } from '@kbn/aiops-plugin/public/components/log_categorization/log_categorization_for_embeddable/log_categorization_for_embeddable'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 1aaa89f
Hi @jgowdyelastic sending design comments below:
![]()
![]() Long term and as I mentioned to Aris, it would be beneficial to consider using EuiDataGrid for this view as well. It would match nicely with the ![]() cc @kertal @davismcphee @ryankeairns for awareness. |
Updated in 13e4b30
Updated in. 13e4b30
Yeah, I think this would be an improvement to the expanded rows. |
…lastic/kibana into pattern-analysis-tab-in-discover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM.
…lastic/kibana into pattern-analysis-tab-in-discover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature! And thanks for addressing the comments!
Some things to consider improving as a follow up:
- What are these warnings
0% contain 3 or more tokens
about? The shown patterns seem to be fine:

-
Noticed that cancelling a patterns request does not always work right away. Is it expected?
-
Once canceled, should there be a button to restart?

Style nits:
- The label is to close to the side:

- Mobile view is a little off:



...gins/discover/public/application/main/components/pattern_analysis/pattern_analysis_table.tsx
Outdated
Show resolved
Hide resolved
...gins/discover/public/application/main/components/pattern_analysis/pattern_analysis_table.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx
Outdated
Show resolved
Hide resolved
Follow on tasks have been added to this meta issue #183922 |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes #178534
Replaces the pattern analysis flyout in Discover with a tab which sits alongside the Documents and Field statistics tabs.
Field selection
Lists all of the text fields in the index. Auto selects
message
, thenerror.message
, thenevent.original
and if none of these fields are available, it just selects the first field in the list.The Options menu provides some configuration options:
Minimum time range
Sets the minimum time range used for the pattern analysis search. The pattern matching results results will be more accurate the more data it sees, so if the user has selected e.g. last 15mins in the time picker, this settings will ensure a wider time range is used to improve the accuracy of the patterns. If the time picker has a larger time range than this setting, the larger time range will be used.
Random sampling
Improves the search performance by using a random sampler. This is the same setting as before.