-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard APM Anomaly rule type with FAAD #179196
Conversation
/ci |
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}); | ||
if (!alerting) { | ||
throw new Error( | ||
'Cannot register anomaly rule type. Both the actions and alerting plugins need to be enabled.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the actions plugin actually required? Can't tell from this PR anyway (or I didn't notice).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right I don't think it's actually required, thanks for catching! I will update the error message in this PR and the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in this commit 193c433
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
…na into move-anomaly-rule-to-faad
@doakalexi I made a minor edit to the PR title and description to clarify that this is for the APM Anomaly rule, rather than the anomaly detection rule under Machine Learning (which has already been onboarded with FAAD).
I believe the Observability team has an indexer tool that's now available from within Kibana, it was a separate repo before. This can create spikes in the data on the fly, but I'm not sure it can create historic data to train the anomaly detection job first which would be necessary for the job to generate anomalies and therefore create alerts. The Obs team might know more. |
Thank you! 🙂 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @doakalexi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
towards: #169867
This PR onboards APM Anomaly rule type with FAAD.
I am having trouble getting this rule to create an alert. If there is any easy way to verify pls let me know!