Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard APM Anomaly rule type with FAAD #179196

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Mar 21, 2024

towards: #169867

This PR onboards APM Anomaly rule type with FAAD.

I am having trouble getting this rule to create an alert. If there is any easy way to verify pls let me know!

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi changed the title Initial commit moving the anomaly rule to faad Onboard Anomaly rule type with FAAD Mar 21, 2024
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Mar 21, 2024
@doakalexi doakalexi self-assigned this Mar 21, 2024
@doakalexi doakalexi requested review from a team, ymao1 and js-jankisalvi March 27, 2024 16:24
@doakalexi doakalexi marked this pull request as ready for review March 27, 2024 16:24
@doakalexi doakalexi requested a review from a team as a code owner March 27, 2024 16:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

});
if (!alerting) {
throw new Error(
'Cannot register anomaly rule type. Both the actions and alerting plugins need to be enabled.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the actions plugin actually required? Can't tell from this PR anyway (or I didn't notice).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I don't think it's actually required, thanks for catching! I will update the error message in this PR and the others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in this commit 193c433

@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Mar 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@peteharverson peteharverson changed the title Onboard Anomaly rule type with FAAD Onboard APM Anomaly rule type with FAAD Mar 28, 2024
@peteharverson
Copy link
Contributor

@doakalexi I made a minor edit to the PR title and description to clarify that this is for the APM Anomaly rule, rather than the anomaly detection rule under Machine Learning (which has already been onboarded with FAAD).

I am having trouble getting this rule to create an alert. If there is any easy way to verify pls let me know!

I believe the Observability team has an indexer tool that's now available from within Kibana, it was a separate repo before. This can create spikes in the data on the fly, but I'm not sure it can create historic data to train the anomaly detection job first which would be necessary for the job to generate anomalies and therefore create alerts. The Obs team might know more.

@doakalexi
Copy link
Contributor Author

@doakalexi I made a minor edit to the PR title and description to clarify that this is for the APM Anomaly rule, rather than the anomaly detection rule under Machine Learning (which has already been onboarded with FAAD).

I believe the Observability team has an indexer tool that's now available from within Kibana, it was a separate repo before. This can create spikes in the data on the fly, but I'm not sure it can create historic data to train the anomaly detection job first which would be necessary for the job to generate anomalies and therefore create alerts. The Obs team might know more.

Thank you! 🙂

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @doakalexi

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@doakalexi doakalexi merged commit 961df45 into elastic:main Apr 2, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

8 participants