Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Error Count Threshold rule type with FAAD #179275

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Mar 22, 2024

Towards: #169867

This PR onboards the Error Count Threshold rule type with FAAD.

To verify

  1. Run the following script to generate APM data:
node scripts/synthtrace many_errors.ts --local --live
  1. Create an error count threshold rule.
    Example:
POST kbn:/api/alerting/rule
{
  "params": {
    "threshold": 25,
    "windowSize": 5,
    "windowUnit": "m",
    "environment": "ENVIRONMENT_ALL"
  },
  "consumer": "alerts",
  "schedule": {
    "interval": "1m"
  },
  "tags": [],
  "name": "testinggg",
  "rule_type_id": "apm.error_rate",
  "notify_when": "onActionGroupChange",
  "actions": []
}
  1. Your rule should create an alert and should saved it in .internal.alerts-observability.apm.alerts-default-000001
    Example:
GET .internal.alerts-*/_search
  1. Recover the alert by setting threshold: 10000

  2. The alert should be recovered and the AAD in the above index should be updated kibana.alert.status: recovered.

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi changed the title Initial commit onboarding the error count rule Onboard Error Count rule type with FAAD Mar 22, 2024
@doakalexi doakalexi changed the title Onboard Error Count rule type with FAAD Onboard Error Count Threshold rule type with FAAD Mar 22, 2024
@doakalexi doakalexi self-assigned this Mar 22, 2024
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Mar 22, 2024
@doakalexi doakalexi requested review from a team, js-jankisalvi and ymao1 March 26, 2024 19:42
@doakalexi doakalexi marked this pull request as ready for review March 26, 2024 19:42
@doakalexi doakalexi requested a review from a team as a code owner March 26, 2024 19:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Mar 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I really love this test section you've kinda standardized - generate data, create rule with DevTools, etc. Nice!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @doakalexi

@doakalexi doakalexi merged commit 3712fa8 into elastic:main Mar 27, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

7 participants