-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Error Count Threshold rule type with FAAD #179275
Onboard Error Count Threshold rule type with FAAD #179275
Conversation
/ci |
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I really love this test section you've kinda standardized - generate data, create rule with DevTools, etc. Nice!
…kibana into move-error-count-rule-to-faad
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @doakalexi |
Towards: #169867
This PR onboards the Error Count Threshold rule type with FAAD.
To verify
Example:
.internal.alerts-observability.apm.alerts-default-000001
Example:
Recover the alert by setting
threshold: 10000
The alert should be recovered and the AAD in the above index should be updated
kibana.alert.status: recovered
.