Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Unify integrations & uncategorized tabs #179413

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Mar 26, 2024

📓 Summary

🛑 DO NOT MERGE

Closes #177696

This work updates the experience when browsing integrations, unifying the Integrations and Uncategorized tabs into a unique view and switching to a more compact UI to inspect multiple integrations simultaneously.

Part of this work also implies:

  • Refactor some areas to make them more composable and configurable in preparation for upcoming work
  • Update the test suite to match the new UX flows
  • Refactor state machines removing unnecessary states/transitions

The drawback of this work is losing the ability to search across the integration's datasets.
For this reason, this PR will be blocked from merging until #177731 is implemented and merged on top of this PR.

demo.mov

@tonyghiani tonyghiani added release_note:enhancement Team:obs-ux-logs Observability Logs User Experience Team labels Mar 26, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani marked this pull request as ready for review April 2, 2024 13:49
@tonyghiani tonyghiani requested a review from a team as a code owner April 2, 2024 13:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@Kerry350 Kerry350 self-requested a review April 3, 2024 10:23
@Kerry350
Copy link
Contributor

Kerry350 commented Apr 4, 2024

Nice work 🙌

All of the ACs are met and working as expected, and the code looks good.

Do we need any issues to track the EUI developments? (The TODOs are probably sufficient to be honest).

Small UI question:

Now that we're using a collapsed approach, do we need to prefix the dataset names with the integration name? (so here for example do we need to repeat [Elastic Agent]? Or could we save some space?

Screenshot 2024-04-04 at 17 04 27

LGTM whilst waiting for the next batch of work based on this.

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Approving but appreciate we won't be merging this yet)

@tonyghiani
Copy link
Contributor Author

Hey @Kerry350 , thanks for the review! Regarding your questions:

Do we need any issues to track the EUI developments?

There is already an ongoing conversation with the EUI team and a tracked issue they will work on:
[EuiFlexGroup][EuiFlexItem] Add polimorphism support for ReactHTML elements

do we need to prefix the dataset names with the integration name?

I showed it to Isabela and this is a mid-term solution until we implement #177701 and show more readable name

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logsExplorer 709 707 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logsExplorer 1.1MB 1.1MB -6.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logsExplorer 56.0KB 56.0KB -7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani
Copy link
Contributor Author

Close as Logs Explorer is deprecated in v9.

@tonyghiani tonyghiani closed this Jan 10, 2025
@tonyghiani tonyghiani deleted the 177696-unify-integrations-uncategorized branch January 10, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Explorer] Unify "Integrations" & "Uncategorized" DataSourceSelector tabs
6 participants