Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable aiAssistantFlyoutMode flag #182633

Merged
merged 2 commits into from
May 7, 2024
Merged

Enable aiAssistantFlyoutMode flag #182633

merged 2 commits into from
May 7, 2024

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented May 5, 2024 •
edited by kibanamachine
Loading

Summary

Enables aiAssistantFlyoutMode flag by default

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski patrykkopycinski marked this pull request as ready for review May 6, 2024 13:23
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 6, 2024 13:23
@patrykkopycinski patrykkopycinski self-assigned this May 6, 2024
@patrykkopycinski patrykkopycinski added Team:Security Generative AI Security Generative AI v8.14.0 release_note:skip Skip the PR/issue when compiling release notes labels May 6, 2024
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 7, 2024 09:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 15.3MB ⚠️ +1.6MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 83.4KB 83.3KB -35.0B
Unknown metric groups

async chunk count

id before after diff
securitySolution 93 95 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit c6c8ee0 into elastic:main May 7, 2024
36 checks passed
@patrykkopycinski patrykkopycinski deleted the feat/assistant-flyout-enable-flag branch May 7, 2024 15:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 7, 2024
@patrykkopycinski
Enable aiAssistantFlyoutMode flag (elastic#182633)
99d1cd7 
## Summary

Enables `aiAssistantFlyoutMode` flag by default

(cherry picked from commit c6c8ee0)
@kibanamachine kibanamachine mentioned this pull request May 7, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 7, 2024
@kibanamachine @patrykkopycinski
[8.14] Enable aiAssistantFlyoutMode flag (#182633) (#182846)
eb4de40 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Enable aiAssistantFlyoutMode flag
(#182633)](#182633)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-05-07T15:14:05Z","message":"Enable
aiAssistantFlyoutMode flag (#182633)\n\n## Summary\r\n\r\nEnables
`aiAssistantFlyoutMode` flag by
default","sha":"c6c8ee062357c6066c8ea49f9917acf068aa2b8b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Security
Generative AI","v8.14.0","v8.15.0"],"title":"Enable
aiAssistantFlyoutMode
flag","number":182633,"url":"https://github.com/elastic/kibana/pull/182633","mergeCommit":{"message":"Enable
aiAssistantFlyoutMode flag (#182633)\n\n## Summary\r\n\r\nEnables
`aiAssistantFlyoutMode` flag by
default","sha":"c6c8ee062357c6066c8ea49f9917acf068aa2b8b"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182633","number":182633,"mergeCommit":{"message":"Enable
aiAssistantFlyoutMode flag (#182633)\n\n## Summary\r\n\r\nEnables
`aiAssistantFlyoutMode` flag by
default","sha":"c6c8ee062357c6066c8ea49f9917acf068aa2b8b"}}]}]
BACKPORT-->

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
@PhilippeOberti PhilippeOberti mentioned this pull request May 10, 2024
Merged
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @kibana-ci @kibanamachine @andrew-goldstein @PhilippeOberti