Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky licensing test #148313 #182712

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix flaky licensing test #148313 #182712

merged 1 commit into from
May 6, 2024
+20 −1

Conversation

afharo
Copy link
Member

@afharo afharo commented May 6, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #148313.

✅ Flaky Test Runner (x200): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5858 🟡 (unrelated failures)

Checklist

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 6, 2024
@afharo afharo self-assigned this May 6, 2024
@afharo afharo marked this pull request as ready for review May 6, 2024 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2024
@afharo afharo requested a review from a team May 6, 2024 16:36
@afharo
Copy link
Member Author

afharo commented May 6, 2024

/ci

@afharo afharo enabled auto-merge (squash) May 6, 2024 17:07
@afharo afharo added backport:all-open Backport to all branches that could still receive a release and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 6, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

TinaHeiligers
TinaHeiligers approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the last time this file was touched 9 months ago and only to unskip a test, changes now should be good!
LGTM!

@afharo afharo merged commit 6740ffb into elastic:main May 6, 2024
32 checks passed
@afharo afharo deleted the 148313-failing-test-license-plugin-api-integration-testsx-packtestlicensing_pluginserverupdatests-licensing-plugin-server-client-changes-in-license-types-properly-recognize-an-enterprise-license branch May 6, 2024 19:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 6, 2024
@afharo
Fix flaky licensing test elastic#148313 (elastic#182712)
e2642d9 
(cherry picked from commit 6740ffb)
@kibanamachine kibanamachine mentioned this pull request May 6, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 6, 2024
@afharo
Fix flaky licensing test elastic#148313 (elastic#182712)
1032198 
(cherry picked from commit 6740ffb)
@kibanamachine kibanamachine mentioned this pull request May 6, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 6, 2024
@kibanamachine @afharo
[8.14] Fix flaky licensing test #148313 (#182712) (#182747)
4cdf84a 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix flaky licensing test #148313
(#182712)](#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
kibanamachine added a commit that referenced this pull request May 6, 2024
@kibanamachine @afharo
[7.17] Fix flaky licensing test #148313 (#182712) (#182746)
0dadb78 
# Backport

This will backport the following commits from `main` to `7.17`:
- [Fix flaky licensing test #148313
(#182712)](#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
@kibanamachine @afharo @adelisle
[7.17] Fix flaky licensing test elastic#148313 (elastic#182712) (elas…
c461516 
…tic#182746)

# Backport

This will backport the following commits from `main` to `7.17`:
- [Fix flaky licensing test elastic#148313
(elastic#182712)](elastic#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
elastic#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

@afharo afharo

Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.22 v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
5 participants
@afharo @elasticmachine @kibana-ci @kibanamachine @TinaHeiligers