Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows][tests] Enable endpoint exceptions integration test #183471

Merged
merged 8 commits into from
May 23, 2024
Merged

[EDR Workflows][tests] Enable endpoint exceptions integration test #183471

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
205c710
extract MINUTES constant
gergoabraham May 15, 2024
ca8426b
enable endpoint exceptions integration test
gergoabraham May 15, 2024
8356bcf
TEMP: run only endpoint exceptions test
gergoabraham May 15, 2024
43b5845
display alerts from the last 24 hours to avoid test fail during midnight
gergoabraham May 15, 2024
76ed911
Revert "TEMP: run only endpoint exceptions test"
gergoabraham May 15, 2024
ef940cc
Merge branch 'main' into enable-endpoint-exceptions-integration-test
kibanamachine May 16, 2024
4487b0a
Merge branch 'main' into enable-endpoint-exceptions-integration-test
kibanamachine May 21, 2024
6c8ef42
Merge branch 'main' into enable-endpoint-exceptions-integration-test
kibanamachine May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions x-pack/test/security_solution_endpoint/apps/integrations/endpoint_exceptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { FtrProviderContext } from '../../ftr_provider_context';
import { targetTags } from '../../target_tags';

export default ({ getPageObjects, getService }: FtrProviderContext) => {
const pageObjects = getPageObjects(['common', 'header']);
const pageObjects = getPageObjects(['common', 'header', 'timePicker']);
const queryBar = getService('queryBar');
const testSubjects = getService('testSubjects');
const endpointTestResources = getService('endpointTestResources');
Expand All @@ -29,11 +29,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const comboBox = getService('comboBox');
const toasts = getService('toasts');

// Failing: See https://github.com/elastic/kibana/issues/176009
describe.skip('Endpoint Exceptions', function () {
const MINUTES = 60_000;

describe('Endpoint Exceptions', function () {
targetTags(this, ['@ess', '@serverless']);

this.timeout(10 * 60_000);
this.timeout(10 * MINUTES);

const clearPrefilledEntries = async () => {
const entriesContainer = await testSubjects.find('exceptionEntriesContainer');
Expand All @@ -50,6 +51,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
};

const openNewEndpointExceptionFlyout = async () => {
await testSubjects.scrollIntoView('timeline-context-menu-button');
await testSubjects.click('timeline-context-menu-button');
await testSubjects.click('add-endpoint-exception-menu-item');
await testSubjects.existOrFail('addExceptionFlyout');
Expand Down Expand Up @@ -102,7 +104,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
};

const checkArtifact = (expectedArtifact: object) => {
return retry.tryForTime(120_000, async () => {
return retry.tryForTime(2 * MINUTES, async () => {
const artifacts = await endpointArtifactTestResources.getArtifacts();

const manifestArtifact = artifacts.find((artifact) =>
Expand Down Expand Up @@ -133,7 +135,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const waitForAlertsToAppear = async () => {
await pageObjects.common.navigateToUrlWithBrowserHistory('security', `/alerts`);
await pageObjects.header.waitUntilLoadingHasFinished();
await retry.waitForWithTimeout('alerts to appear', 10 * 60_000, async () => {
await pageObjects.timePicker.setCommonlyUsedTime('Last_24 hours');
await retry.waitForWithTimeout('alerts to appear', 10 * MINUTES, async () => {
await queryBar.clickQuerySubmitButton();
return testSubjects.exists('timeline-context-menu-button');
});
Expand Down Expand Up @@ -164,6 +167,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

it('should add `event.module=endpoint` to entry if only wildcard operator is present', async () => {
await pageObjects.common.navigateToUrlWithBrowserHistory('security', `/alerts`);
await pageObjects.timePicker.setCommonlyUsedTime('Last_24 hours');

await openNewEndpointExceptionFlyout();
await clearPrefilledEntries();
Expand Down Expand Up @@ -208,6 +212,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

it('should NOT add `event.module=endpoint` to entry if there is another operator', async () => {
await pageObjects.common.navigateToUrlWithBrowserHistory('security', `/alerts`);
await pageObjects.timePicker.setCommonlyUsedTime('Last_24 hours');

await openNewEndpointExceptionFlyout();
await clearPrefilledEntries();
Expand Down