-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset Quality]Add logic to display degraded fields in DQ Flyout #183934
[Dataset Quality]Add logic to display degraded fields in DQ Flyout #183934
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
x-pack/plugins/observability_solution/observability/server/utils/queries.ts
Show resolved
Hide resolved
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass and left some notes, I think the new API is not versioned and it requires to update the implementation to comply with the specs, good job overall 👌
x-pack/plugins/observability_solution/dataset_quality/common/api_types.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/common/api_types.ts
Outdated
Show resolved
Hide resolved
.../observability_solution/dataset_quality/public/components/flyout/degraded_fields/columns.tsx
Outdated
Show resolved
Hide resolved
...bility_solution/dataset_quality/public/components/flyout/degraded_fields/degraded_fields.tsx
Show resolved
Hide resolved
...ns/observability_solution/dataset_quality/public/hooks/use_dataset_quality_degraded_field.ts
Outdated
Show resolved
Hide resolved
...ns/observability_solution/dataset_quality/public/hooks/use_dataset_quality_degraded_field.ts
Outdated
Show resolved
Hide resolved
...lution/dataset_quality/public/state_machines/dataset_quality_controller/src/state_machine.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/server/routes/data_streams/routes.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/server/routes/data_streams/routes.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/server/routes/data_streams/routes.ts
Show resolved
Hide resolved
@flash1293 Thank you for pointing it out. I have fixed it now |
Thanks @achyutjhunjhunwala ! One other note about the user experience - should we indicate somehow if the list of ignored fields is not exhaustive? In the simplest way it would just be a mention in the tooltip: https://github.com/elastic/kibana/pull/183934/files#diff-e14f87ebe930d154e4d8be9da8d99811c8a756fca476f339edaaa62009c5c257R147 |
@flash1293 Sounds good to me. I will proceed with something like this @mdbirnstiehl Can you help me here with a better copy ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the changes!
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: |
'xpack.datasetQuality.flyoutDegradedFieldsSectionTooltip', | ||
{ | ||
defaultMessage: | ||
'Set of degraded fields in the dataset. Please not that this list may not be exhaustive.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a typo here. "Please note..." instead of "Please not..." You can probably remove that part anyway and just say "This list may not be exhaustive." We could also change the tooltip a little more and say, "A partial list of degraded fields found in your dataset." to imply that it's not exhaustive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @mdbirnstiehl I will go with "A partial list of degraded fields found in your dataset."
and update the tooltip in my next PR
Summary
Closes #172265
Description
This PR adds the Degraded Fields Table to the Dataset Quality Flyout for individual Data Stream. Following tasks were done as part of this PR
datastream
directly and aggregates_ignored
fields for that data stream during the given time range and also adds a sub aggregation for last occurence.Screenshot
Scenario