-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Advanced settings] Hide Defer loading panels below "the fold"
setting
#184090
[Advanced settings] Hide Defer loading panels below "the fold"
setting
#184090
Conversation
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config changes LGTM, just a left a q about the nature of the setting.
enableESQL: true | ||
# Disables `Defer loading panels below "the fold"` | ||
labs:dashboard:deferBelowFold: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how does this affect performance of dashboards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone from @elastic/kibana-presentation answer this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are any metrics captured to quantify the effect of this setting. @thomasneirynck has been capturing dashboard load metrics. Thomas, do you have any data about effects of "Defer loading panels below "the fold" setting on dashboard load performance?
The best practices for dashboards are to avoid large dashboards that need scrolling and instead use links panel to create smaller dashboards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nreese no, we don't track this setting metric in any of the performance journeys
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @yuliacech |
Fixes #183166
Summary
This small PR hides the previously mentioned setting in serverless and adds a uiOverride to keep it always disabled too.
How to test