Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced settings] Hide Defer loading panels below "the fold" setting #184090

Merged
merged 5 commits into from
May 27, 2024

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented May 23, 2024

Fixes #183166

Summary

This small PR hides the previously mentioned setting in serverless and adds a uiOverride to keep it always disabled too.

How to test
  • Verify that the setting is disabled and hidden for serverless
  • Verify that the setting is still functional for onprem

@sabarasaba sabarasaba self-assigned this May 23, 2024
@sabarasaba
Copy link
Member Author

/ci

@sabarasaba sabarasaba added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 labels May 23, 2024
@sabarasaba sabarasaba marked this pull request as ready for review May 23, 2024 10:26
@sabarasaba sabarasaba requested review from a team as code owners May 23, 2024 10:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config changes LGTM, just a left a q about the nature of the setting.

enableESQL: true
# Disables `Defer loading panels below "the fold"`
labs:dashboard:deferBelowFold: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how does this affect performance of dashboards?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone from @elastic/kibana-presentation answer this please?

Copy link
Contributor

@nreese nreese May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any metrics captured to quantify the effect of this setting. @thomasneirynck has been capturing dashboard load metrics. Thomas, do you have any data about effects of "Defer loading panels below "the fold" setting on dashboard load performance?

The best practices for dashboards are to avoid large dashboards that need scrolling and instead use links panel to create smaller dashboards

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nreese no, we don't track this setting metric in any of the performance journeys

@yuliacech yuliacech assigned yuliacech and unassigned sabarasaba May 24, 2024
@yuliacech yuliacech enabled auto-merge (squash) May 24, 2024 11:20
@yuliacech yuliacech disabled auto-merge May 24, 2024 11:21
@yuliacech yuliacech enabled auto-merge (squash) May 27, 2024 17:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yuliacech

@yuliacech yuliacech merged commit a526914 into elastic:main May 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
8 participants