Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Recognize transformational commands with ast parsing #184291

Merged
merged 1 commit into from
May 27, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 27, 2024

Summary

Closes #184139

It uses ast parsing to recognize if the query has a transformational command. Although I added metrics on the list it wont work for it until we support it on our ast system. I am just adding here proactively. Stats and keep should work as expected though

image

Checklist

@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-utils 50 52 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 810.5KB 810.6KB +116.0B
unifiedHistogram 73.6KB 73.6KB +68.0B
total +184.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-utils 52 54 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added release_note:fix backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.15.0 labels May 27, 2024
@stratoula stratoula marked this pull request as ready for review May 27, 2024 08:24
@stratoula stratoula requested review from a team as code owners May 27, 2024 08:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM

@stratoula stratoula merged commit abd55fb into elastic:main May 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] [Discover] Commenting out a stats / keep doesnt resolve the Document view
4 participants