Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-side logging: allow per-logger level configuration #184568

Merged

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented May 31, 2024

Summary

Part of #144276
Somewhat related to #184520

Allow to configure level of individual browser-side loggers

Example:

logging.browser:
    loggers:
       - name: analytics 
         level: debug

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels May 31, 2024
@pgayvallet pgayvallet marked this pull request as ready for review May 31, 2024 12:10
@pgayvallet pgayvallet requested a review from a team as a code owner May 31, 2024 12:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pgayvallet pgayvallet enabled auto-merge (squash) June 3, 2024 05:52
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 3, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-logging-common-internal 31 34 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 416.9KB 417.2KB +292.0B
Unknown metric groups

API count

id before after diff
@kbn/core-logging-common-internal 38 41 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 76837c0 into elastic:main Jun 3, 2024
17 of 18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants