Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart support for array values in Metric #184886

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add chart support for array values in Metric #184886

wants to merge 6 commits into from

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jun 6, 2024 •
edited
Loading

Summary

Adds support for array of values on new Metric with changes from elastic/elastic-charts#2428.

image

related to #160815

@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens labels Jun 6, 2024
@nickofthyme nickofthyme marked this pull request as ready for review June 20, 2024 22:12
@nickofthyme nickofthyme requested a review from a team as a code owner June 20, 2024 22:12
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 20, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations progress bar direction controls hides direction controls if bar not showing
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations progress bar direction controls hides direction controls if bar not showing
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations progress bar direction controls toggles progress direction
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations progress bar direction controls toggles progress direction
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should disable bar when max dimension does not exist
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should disable bar when max dimension does not exist
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should disable trendline when no default time field
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should disable trendline when no default time field
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should enable bar when max dimension exists
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should enable bar when max dimension exists
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should enable trendline when default time field exists
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state should enable trendline when default time field exists
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is false and maximum value is not defined, option none should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is false and maximum value is not defined, option none should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and maximum value is not defined, bar should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and maximum value is not defined, bar should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and trendline is defined, line should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and trendline is defined, line should be selected
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons enables bar
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons enables bar
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons enables trendline
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons enables trendline
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons selects none from bar
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons selects none from bar
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons selects none from trendline
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations responding to buttons selects none from trendline
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations should disable trendline when a metric dimension has a reduced time range
  • [job] [logs] Jest Tests #9 / dimension editor additional section supporting visualizations should disable trendline when a metric dimension has a reduced time range

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 570 571 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 4.9KB 5.5KB +604.0B
lens 1.5MB 1.5MB +207.0B
total +811.0B
Unknown metric groups

API count

id before after diff
lens 672 674 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme changed the title Add support for array values in Metric Add chart support for array values in Metric Jul 2, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 3, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / APM API tests correlations/field_candidates.spec.ts trial no archive field candidates without data handles the empty state
  • [job] [logs] FTR Configs #2 / APM API tests correlations/field_candidates.spec.ts trial no archive field candidates without data handles the empty state
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations progress bar direction controls hides direction controls if bar not showing
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations progress bar direction controls hides direction controls if bar not showing
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations progress bar direction controls toggles progress direction
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations progress bar direction controls toggles progress direction
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should disable bar when max dimension does not exist
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should disable bar when max dimension does not exist
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should disable trendline when no default time field
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should disable trendline when no default time field
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should enable bar when max dimension exists
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should enable bar when max dimension exists
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should enable trendline when default time field exists
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state should enable trendline when default time field exists
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is false and maximum value is not defined, option none should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is false and maximum value is not defined, option none should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and maximum value is not defined, bar should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and maximum value is not defined, bar should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and trendline is defined, line should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations reflecting visualization state when showBar is true and trendline is defined, line should be selected
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons enables bar
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons enables bar
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons enables trendline
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons enables trendline
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons selects none from bar
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons selects none from bar
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons selects none from trendline
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations responding to buttons selects none from trendline
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations should disable trendline when a metric dimension has a reduced time range
  • [job] [logs] Jest Tests #4 / dimension editor additional section supporting visualizations should disable trendline when a metric dimension has a reduced time range

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 570 571 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 4.9KB 5.0KB +42.0B
lens 1.5MB 1.5MB +207.0B
total +249.0B
Unknown metric groups

API count

id before after diff
lens 672 674 +2

History

@nickofthyme nickofthyme mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 left review comments

@MichaelMarcialis MichaelMarcialis MichaelMarcialis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickofthyme @kibana-ci @elasticmachine @dej611 @MichaelMarcialis