[Package][Expandable flyout] - fix Storybook #185036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| }, | ||
| preview: [], | ||
| } as unknown as State; |
There was a problem hiding this comment.
should remove these as uknown as that are present throughout the tests, or else this is highly likely to happen again in the future
There was a problem hiding this comment.
thanks for pointing this out, removed here
PhilippeOberti
force-pushed
the
expandable-flyout-package-storybook
branch
from
a7c2048
to
8b8b3ac
Compare
lgestc
approved these changes
Jun 11, 2024
|
🎊 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
kbn-expandable-flyoutpackage storybook.There were 3 issues:
<i18nProvider>error, introduced by this PR and that will be fixed with this PR<i18nProvider>in ourTestProviderfile, which highlighted the prior pointScreen.Recording.2024-06-07.at.12.24.23.PM.mov
Notes
We need to wait for #185033 to be merged before testing this (I cherry picked the changes to test locally before opening the PR).