Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Update function definitions #185632

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kibanamachine
Copy link
Contributor

This PR updates the function definitions based on the latest metadata from Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner June 10, 2024 04:13
@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels Jun 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

/ci

testErrorsAndWarnings('from a_index | eval mv_zip(booleanField, booleanField)', [
'Argument of [mv_zip] must be [string], found value [booleanField] type [boolean]',
'Argument of [mv_zip] must be [string], found value [booleanField] type [boolean]',
]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these mv_zip tests have been added here? It only added the repeat function 🤔 cc @drewdaemon

Copy link
Contributor

@drewdaemon drewdaemon Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must not have run make:tests manually after updating the mv_zip definition. I don't think we need to worry.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB +654.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana v8.15.0 labels Jun 10, 2024
@stratoula stratoula merged commit bfa3431 into main Jun 10, 2024
26 checks passed
@stratoula stratoula deleted the esql_generate_function_definitions_1717992805 branch June 10, 2024 07:53
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 10, 2024
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Jun 13, 2024
This PR updates the function definitions based on the latest metadata
from Elasticsearch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants