Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.0.0 #185943

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Upgrade EUI to v95.0.0 #185943

merged 13 commits into from
Jun 18, 2024

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jun 11, 2024

v94.6.0v95.0.0-backport.0

Questions? Please see our Kibana upgrade FAQ.


v95.0.0-backport.0

This is a backport release only intended for use by Kibana.

  • Updated EuiSteps to support a new titleSize="xxs" style, which outputs the same title font size but smaller unnumbered step indicators (#7813)
  • Updated EuiStepsHorizontal to support a new size="xs" style, which outputs smaller unnumbered step indicators (#7813)
  • Updated EuiStepNumber to support new titleSize="none" which omits rendering step numbers, and will only render icons (#7813)

v95.0.0

  • Added move glyph to EuiIcon (#7789)
  • Updated EuiBasicTable and EuiInMemoryTables with selection - the header row checkbox will now render an indeterminate state if some (but not all) rows are selected (#7817)

Bug fixes

  • Fixed an EuiDataGrid visual bug when using lineCount row heights where the clamped text was still visible for some font sizes (#7793)
  • Fixed EuiSearchBar's filter configs to always respect autoClose: false (#7806)

Breaking changes

  • Removed deprecated EUI_CHARTS_THEME_DARK, EUI_CHARTS_THEME_LIGHT and EUI_SPARKLINE_THEME_PARTIAL exports (#7682)
  • Removed deprecated euiPalettePositive and euiPaletteNegative. Use euiPaletteGreen and euiPaletteRed instead (#7808)
  • Removed type="inList" from EuiCheckbox. Simply omit passing a label prop to render this style of checkbox (#7814)
  • Removed the unused compressed prop from EuiCheckbox and EuiRadio. This prop was not doing anything on individual components. (#7818)

CSS-in-JS conversions

  • Converted EuiCheckboxGroup to Emotion (#7818)
  • Converted EuiRadioGroup to Emotion (#7818)

@tkajtoch tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v8.15.0 labels Jun 11, 2024
@tkajtoch tkajtoch self-assigned this Jun 11, 2024
@tkajtoch tkajtoch force-pushed the feat/eui-95.0.0 branch 4 times, most recently from a9c142b to 5b06765 Compare June 12, 2024 12:02
@tkajtoch
Copy link
Member Author

buildkite test this

@cee-chen
Copy link
Member

/ci

@cee-chen
Copy link
Member

@tkajtoch I can't seem to repro the Observability Cypress failures locally 😬 Not sure if you can!

@tkajtoch
Copy link
Member Author

@cee-chen Same. I tried reproducing these before and after rebase, and they all pass locally

@cee-chen cee-chen marked this pull request as ready for review June 14, 2024 00:38
@cee-chen cee-chen requested review from a team as code owners June 14, 2024 00:38
@cee-chen cee-chen requested review from a team as code owners June 14, 2024 00:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presentation changes lgtm!

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes in cypress suites LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 17, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 47 46 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +3.0B
controls 202.0KB 202.0KB -14.0B
dataViewFieldEditor 176.3KB 176.3KB +3.0B
enterpriseSearch 2.7MB 2.7MB -11.0B
exploratoryView 182.0KB 182.0KB +3.0B
fileUpload 951.8KB 951.8KB +3.0B
fleet 1.4MB 1.4MB +16.0B
indexManagement 661.7KB 661.7KB +3.0B
infra 1.6MB 1.6MB -2.0KB
ingestPipelines 373.3KB 373.3KB +3.0B
kubernetesSecurity 213.9KB 212.0KB -1.9KB
logsShared 138.4KB 138.4KB +3.0B
maps 3.0MB 3.0MB -1.9KB
monitoring 533.3KB 533.3KB +3.0B
security 587.8KB 587.8KB -14.0B
securitySolution 13.6MB 13.6MB -11.0B
stackAlerts 79.7KB 79.7KB +34.0B
synthetics 1.0MB 1.0MB +3.0B
uptime 467.2KB 467.2KB -11.0B
visTypeVega 1.8MB 1.8MB -2.0KB
total -7.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 415.4KB 415.5KB +114.0B
kbnUiSharedDeps-css 241.2KB 240.9KB -241.0B
kbnUiSharedDeps-npmDll 6.3MB 6.0MB -310.7KB
kbnUiSharedDeps-srcJs 3.2MB 3.2MB -104.0B
observability 123.0KB 123.0KB +3.0B
total -310.9KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 56 55 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search/Search area changes look good.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra Services change LGTM

@cee-chen cee-chen merged commit 946a255 into elastic:main Jun 18, 2024
42 checks passed
bhapas pushed a commit to bhapas/kibana that referenced this pull request Jun 18, 2024
`v94.6.0` ⏩ `v95.0.0-backport.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

##
[`v95.0.0-backport.0`](https://github.com/elastic/eui/releases/v95.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

- Updated `EuiSteps` to support a new `titleSize="xxs"` style, which
outputs the same title font size but smaller unnumbered step indicators
([elastic#7813](elastic/eui#7813))
- Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which
outputs smaller unnumbered step indicators
([elastic#7813](elastic/eui#7813))
- Updated `EuiStepNumber` to support new `titleSize="none"` which omits
rendering step numbers, and will only render icons
([elastic#7813](elastic/eui#7813))

## [`v95.0.0`](https://github.com/elastic/eui/releases/v95.0.0)

- Added `move` glyph to `EuiIcon`
([elastic#7789](elastic/eui#7789))
- Updated `EuiBasicTable` and `EuiInMemoryTable`s with `selection` - the
header row checkbox will now render an indeterminate state if some (but
not all) rows are selected
([elastic#7817](elastic/eui#7817))

**Bug fixes**

- Fixed an `EuiDataGrid` visual bug when using `lineCount` row heights
where the clamped text was still visible for some font sizes
([elastic#7793](elastic/eui#7793))
- Fixed `EuiSearchBar`'s filter configs to always respect `autoClose:
false` ([elastic#7806](elastic/eui#7806))

**Breaking changes**

- Removed deprecated `EUI_CHARTS_THEME_DARK`, `EUI_CHARTS_THEME_LIGHT`
and `EUI_SPARKLINE_THEME_PARTIAL` exports
([elastic#7682](elastic/eui#7682))
- Removed deprecated `euiPalettePositive` and `euiPaletteNegative`. Use
`euiPaletteGreen` and `euiPaletteRed` instead
([elastic#7808](elastic/eui#7808))
- Removed `type="inList"` from `EuiCheckbox`. Simply omit passing a
`label` prop to render this style of checkbox
([elastic#7814](elastic/eui#7814))
- Removed the unused `compressed` prop from `EuiCheckbox` and
`EuiRadio`. This prop was not doing anything on individual components.
([elastic#7818](elastic/eui#7818))

**CSS-in-JS conversions**

- Converted `EuiCheckboxGroup` to Emotion
([elastic#7818](elastic/eui#7818))
- Converted `EuiRadioGroup` to Emotion
([elastic#7818](elastic/eui#7818))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.