[ES|QL] remove chrono literals #186536
Merged
[ES|QL] remove chrono literals #186536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
drewdaemon
added
Feature:ES|QL
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
reviewed
Jul 10, 2024
| optional: false, | ||
| literalOptions: [ |
There was a problem hiding this comment.
Why are we repeating them here and not adding them to a common place that can be reused?
There was a problem hiding this comment.
Do you mean define an array and reuse it between the generator script and the file it generates (this file)?
There was a problem hiding this comment.
Ja!! (to change only in one place)
stratoula
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "chrono-literals" can be replaced with the simpler system of
literalOptions. This is better because it moves us toward having one way to do things and removing Kibana-specific types which don't actually exist in ES|QL and, therefore, can be confusing.