Onboard Synthetics TLS rule type with FAAD #186551
Conversation
|
/ci |
|
/ci |
doakalexi
changed the title
|
/ci |
|
/ci |
doakalexi
added
the
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
doakalexi
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
| spaceId, | ||
| indexedStartedAt, | ||
| alertsLocator, | ||
| basePath.publicBaseUrl | ||
| ), | ||
| ...updateState(ruleState, foundCerts), |
There was a problem hiding this comment.
@ymao1 is the correct place for this?
There was a problem hiding this comment.
I assume Ying has more knowledge here, but this doesn't seem quite right, especially since we're calling it again in the return of the executor. And it doesn't look these fields were in the context before.
There was a problem hiding this comment.
Yea, I think you want to set the state during the initial reporting of the alert:
const { uuid, start } = alertsClient.report({
id: alertId,
actionGroup: TLS_CERTIFICATE.id,
state: { ...updateState(ruleState, foundCerts), ...summary },
});
There was a problem hiding this comment.
okay thanks! I thought it was weird but wanted to make sure 🙂
There was a problem hiding this comment.
Resolved in this commit 1068617
💚 Build Succeeded
Metrics [docs]History
To update your PR or re-run it, just comment with: |
| spaceId, | ||
| indexedStartedAt, | ||
| alertsLocator, | ||
| basePath.publicBaseUrl | ||
| ), | ||
| ...updateState(ruleState, foundCerts), |
There was a problem hiding this comment.
I assume Ying has more knowledge here, but this doesn't seem quite right, especially since we're calling it again in the return of the executor. And it doesn't look these fields were in the context before.
x-pack/plugins/observability_solution/synthetics/server/alert_rules/tls_rule/message_utils.ts
Show resolved
Hide resolved
|
@MiriamAparicio Were you able to generate active alerts and then recover & verify that the alert documents contain the expected information? |
|
hi @ymao1, |
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💚 Build Succeeded
Metrics [docs]History
|
Resolves: #169867
This PR onboards the Synthetics TLS rule type with FAAD.
I can't get this rule to alert easily to help verify, pls let me know if there is a good way to test.