[console_extensions] disable when console is disabled #18673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
review
Feature:Console
jen-huang
approved these changes
Apr 30, 2018
💔 Build Failed |
💚 Build Succeeded |
|
Doesn’t this mean you can no longer disable console_extensions alone? If so, was that intended? |
|
Good catch, pushed an update. |
jbudz
force-pushed
the
console-extensions-enabled
branch
from
6496203 to
b5f632e
Compare
💚 Build Succeeded |
epixa
reviewed
May 1, 2018
| isEnabled(config) { | ||
| return ( | ||
| config.get('console_extensions.enabled') && | ||
| config.has('console.enabled') && |
There was a problem hiding this comment.
Why do you need a call to has for console but not for console_extensions?
There was a problem hiding this comment.
Our tests load x-pack plugins in isolation, and if there's no console to go along with console_extensions it'll error out. I was trying to find somewhere to mock console, but I decided it's a moderately legitimate check.
There was a problem hiding this comment.
I didn't even answer your question, doh. I didn't do has for console_extensions because I defined it in the schema below.
|
LGTM |
jbudz
added a commit
that referenced
this pull request
May 1, 2018
* [console_extensions] disable when console is disabled * [console extensions] has console and enabled * [console_extensions] fix console_extensions.enabled
jbudz
added a commit
that referenced
this pull request
May 1, 2018
* [console_extensions] disable when console is disabled * [console extensions] has console and enabled * [console_extensions] fix console_extensions.enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18671.
To test, set
console.enabledto false. The server should start with no errors.Without this change,
is expected on server start