-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataViews] Use client-side authc.getCurrentUser from core.security #186856
[DataViews] Use client-side authc.getCurrentUser from core.security #186856
Conversation
26db7aa
to
548fcbe
Compare
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small PR that simplifies things a tad more here: tsullivan#12
9297aa1
to
c7346e6
Compare
c7346e6
to
c73e220
Compare
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Summary
Part of #186574
Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0. The Data Views plugin uses the
authc.getCurrentUser
method as a means to use the user's profile_uid for creating a user-hash which is sent as a field in the headers of a particular request.What makes this example interesting: Data Views was not able to have a direct dependency on the Security plugin due to issues with a circular dependency. As a workaround, it used the
coreSetup.plugins.onStart
Promise to use Security services in a non-contractual way. The change in this PR does away with the workaround and allows Data Views to consume the Security service in a more typical way.Checklist
Delete any items that are not applicable to this PR.