Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate authc dependency from security plugin to core security service #187124

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Migrate authc dependency from security plugin to core security service #187124

merged 4 commits into from
Jun 30, 2024

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jun 27, 2024 •
edited
Loading

Summary

Part of #186574

Background: This PR is an example of a plugin migrating away from depending on the Security plugin, which is a high-priority effort for the last release before 9.0. The Cases plugin uses authc.getCurrentUser from the security plugin's start contract on the server side.

This PR migrates authc.getCurrentUser from the security plugin start contract to the core security service.

Checklist

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0 labels Jun 27, 2024
@TinaHeiligers TinaHeiligers requested a review from tsullivan June 27, 2024 23:49
@TinaHeiligers
Copy link
Contributor Author

/ci

@TinaHeiligers TinaHeiligers marked this pull request as ready for review June 28, 2024 17:12
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner June 28, 2024 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed the code

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) June 30, 2024 20:16
@TinaHeiligers TinaHeiligers merged commit 4eb07b1 into elastic:main Jun 30, 2024
19 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
cases 33 31 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 30, 2024
@cnasikas cnasikas mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TinaHeiligers @elasticmachine @kibana-ci @tsullivan @adcoelho @kibanamachine