[Embeddables Rebuild] Create & copy panels with runtime state #188039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
loe:small
ThomThomson
added
Team:Presentation
|
/ci |
|
/ci |
…eateAndCopyWithRuntimeState' into reactEmbeddables/createAndCopyWithRuntimeState
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
added
the
release_note:skip
nickpeihl
approved these changes
Jul 15, 2024
| ); | ||
| const linksToSave: Link[] | undefined = state.links | ||
| ?.map(({ title, description, error, ...linkToSave }) => linkToSave) | ||
| ?.map( |
There was a problem hiding this comment.
Can we add a comment why we're doing this? Maybe something like this?
Suggested change
| ?.map( | |
| // Remove any properties with null values that may have been serialized when backing up runtimeState | |
| ?.map( |
There was a problem hiding this comment.
Good call, added in b687476
…eateAndCopyWithRuntimeState' into reactEmbeddables/createAndCopyWithRuntimeState
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @ThomThomson |
kibanamachine
added
v8.16.0
backport:skip
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expands the work done in #186052 to make the new Embeddable framework use runtime state for creating new panels, and for passing panel state around in the state transfer service (copy to Dashboard etc).
Now, only loading from a Dashboard saved object should result in State that needs to be deserialized.