[ML] Hide Top Influencers list if job has no influencers #18819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
jgowdyelastic
approved these changes
May 8, 2018
| } | ||
|
|
||
| const influencers = mlJobService.getJob(id).analysis_config.influencers || []; |
There was a problem hiding this comment.
just to be defensive, it might be best not to assume getJob will aways return a job.
splitting this line into
const tempJob = mlJobService.getJob(id);
const influencers = (tempJob === undefined) ? [] : tempJob.analysis_config.influencers;
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 8, 2018
* [ML] Hide Top Influencers list if job has no influencers * [ML] Add check for undefined job when hiding influencers list
peteharverson
added a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the Top Influencers list from the Anomaly Explorer if the selected job(s) have no influencers configured.
When viewing a job with no influencers, an info icon is shown in the top left corner of the view to clarify why the list is hidden.
Fixes #18456