Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Fix regenerate button with LangGraph #188249

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jul 12, 2024

Summary

Fixes regenerate button with LangGraph. To test, ensure assistantKnowledgeBaseByDefault feature flag is on or #188168 has merged.

Before

bad.mov

After

good.mov

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v8.15.0 v8.16.0 labels Jul 12, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner July 12, 2024 16:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected. Thank you for fixing this!

@stephmilovic stephmilovic merged commit f72a321 into elastic:main Jul 13, 2024
36 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 13, 2024
) (#188276)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security solution] Fix regenerate button with LangGraph
(#188249)](#188249)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-07-13T14:16:12Z","message":"[Security
solution] Fix regenerate button with LangGraph
(#188249)","sha":"f72a321a9c80b8c9ccb30f30a5870200989e3ae1","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Team:Security Generative
AI","v8.15.0","v8.16.0"],"title":"[Security solution] Fix regenerate
button with
LangGraph","number":188249,"url":"https://github.com/elastic/kibana/pull/188249","mergeCommit":{"message":"[Security
solution] Fix regenerate button with LangGraph
(#188249)","sha":"f72a321a9c80b8c9ccb30f30a5870200989e3ae1"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188249","number":188249,"mergeCommit":{"message":"[Security
solution] Fix regenerate button with LangGraph
(#188249)","sha":"f72a321a9c80b8c9ccb30f30a5870200989e3ae1"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants