-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Status overview embeddable #188807
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
* 2.0. | ||
*/ | ||
|
||
export const STATUS_OVERVIEW_EMBEDDABLE = 'STATUS_OVERVIEW_EMBEDDABLE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahzad31 This is the name with which the embeddable gets registered to the embeddable registry. I recommend synthetics is include in the name, something like SYNTHETICS_OVERVIEW_EMBEDDABLE
...on/synthetics/public/apps/embeddables/status_overview/status_overview_embeddable_factory.tsx
Outdated
Show resolved
Hide resolved
...on/synthetics/public/apps/embeddables/status_overview/status_overview_embeddable_factory.tsx
Outdated
Show resolved
Hide resolved
fetchSubscription.unsubscribe(); | ||
}; | ||
}, []); | ||
return <StatusOverviewComponent reload$={reload$} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahzad31 Every embeddable needs to have a data-shared-item=""
in order to not report timeout errors in the Kibana screenshot tool. In the Dashboard app you have the option to export the Dashboard as PDF.
Right now it reports a timeout error because it is missing this attribute. Try to add following:
<div
data-shared-item="" // TODO: Remove data-shared-item and data-rendering-count as part of https://github.com/elastic/kibana/issues/179376
>
<StatusOverviewComponent />
</div>
This manual adding of the data-shared-item attribute in each embeddable is temporary and should be holistically addressed later on in this issue.
You can find more information about this here
@shahzad31 In general it looks good! I was able to add a new Synthetics Status Overview embeddable. I left a few comments regarding removing the edit option from your embeddable and adding the
|
@ThomThomson This is a new Observebility embeddable that @shahzad31 is adding! |
@shahzad31 Can you make the new Synthetics panel clickable, so when users click on the panel, they are redirected to the Synthetics app? We should also think how we handle empty state. When user has no monitors set up, we should display message and a link to the Synthetics app. |
...on/synthetics/public/apps/embeddables/status_overview/status_overview_embeddable_factory.tsx
Outdated
Show resolved
Hide resolved
...on/synthetics/public/apps/embeddables/status_overview/status_overview_embeddable_factory.tsx
Outdated
Show resolved
Hide resolved
...on/synthetics/public/apps/embeddables/status_overview/status_overview_embeddable_factory.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana.jsonc lgtm
…kibana into status-overview-panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR. As discussed we will handle the clicking/filtering/empty state in a follow up PR!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@mgiota thanks for the tag! One thing I'm noticing straight away here is that the status doesn't stretch to fill the vertical panel space on the Dashboard. This makes me worry that if the panel is too small content will be cut off. @andreadelrio would you mind helping out with a design audit of this? @nreese we should prioritize that functional test that fails when a new item is added to the |
Summary
Added status overview embeddable !!
status.panel.mov