[Threat Hunting Investigations][OpenAPI] Use timeline's generated enums #189410
Conversation
janmonschke
added
release_note:skip
| @@ -717,11 +664,6 @@ export interface SortTimeline { | |||
| sortOrder: Direction; | |||
| } | |||
|
|
|||
| export interface ExportTimelineNotFoundError { | |||
There was a problem hiding this comment.
This type was duplicated in this file, so I removed one of them
| export interface KueryFilterQueryResult { | ||
| kind?: Maybe<string>; | ||
| expression?: Maybe<string>; | ||
| } | ||
|
|
||
| export interface SerializedKueryQueryResult { |
There was a problem hiding this comment.
This one I moved around to match the dependency flow of these types
| zeek = 'zeek', | ||
| } | ||
| export const RowRendererCount = Object.keys(RowRendererIdEnum).length; | ||
| export const RowRendererValues = Object.values(RowRendererId.Values); |
There was a problem hiding this comment.
Object.values(RowRendererId.Values) was copied in a bunch of places, so I created this shared export
| threat_match = 'threat_match', | ||
| zeek = 'zeek', | ||
| } | ||
| export const RowRendererCount = Object.keys(RowRendererIdEnum).length; |
There was a problem hiding this comment.
Similar to the previous version, but uses RowRendererIdEnum now.
janmonschke
changed the title
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| type: DataProviderType.optional(), | ||
| }); | ||
|
|
||
| export type DataProviderResult = z.infer<typeof DataProviderResult>; |
There was a problem hiding this comment.
Ah, nice catch here. I'm pretty sure I based the original version of this type here, but that is slightly different from the validation schema. 👌🏾
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: cc @janmonschke |
Summary
Fixes https://github.com/elastic/security-team/issues/10132.
This PR is the first on in a series of PRs to adopt the newly generate OpenAPI types in the timeline server code base. As a first step, we're migrating to the newly generated enums only. This has almost no impact on the schemas and is mostly a one-to-one change.
Despite there being changes in more than 150 files, the review should be pretty straight-forward. The most changes come from the new distinction of enums and the actual type of an enum. Meaning a lot of imports and enum usages needed a simple change.
In some places I found duplicate or unused types and the OpenAPI types still had a couple of minor mistakes.